Skip to content

UtilityTokenAbstract: construct with and expose UUID invariants - #97

Merged
benjaminbollen merged 1 commit into
developfrom
jasonbanks/gh91/pass-uuid-parameters
Jan 31, 2018
Merged

UtilityTokenAbstract: construct with and expose UUID invariants#97
benjaminbollen merged 1 commit into
developfrom
jasonbanks/gh91/pass-uuid-parameters

Conversation

@jasonklein

@jasonklein jasonklein commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

✋ Merge after #100 is merged and this is rebased on develop.

For UtilityTokenAbstract:

  • includes UUID params as constructor arguments (and makes attendant changes up through to OpenSTUtility)
  • confirms that hash of UUID params matches UUID
  • stores and exposes previously unexposed attributes of the UUID: conversion rate, value chain ID, utility chain ID, and protocol address

🚨 OpenSTUtility has "a lot" of changes because the linter didn't like the order of functions (external before public, constructor before external)

Fixes #91.

@jasonklein
jasonklein force-pushed the jasonbanks/gh91/pass-uuid-parameters branch 2 times, most recently from 226d892 to e030c08 Compare January 30, 2018 16:13
@jasonklein jasonklein added this to the v0.9.2 milestone Jan 30, 2018
@jasonklein
jasonklein force-pushed the jasonbanks/gh91/pass-uuid-parameters branch from e030c08 to 520d4c3 Compare January 30, 2018 17:52

@benjaminbollen benjaminbollen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; will wait for rebase

…for UtilityTokenAbstract; expose conversion rate. Relates to #91
@jasonklein
jasonklein force-pushed the jasonbanks/gh91/pass-uuid-parameters branch from 520d4c3 to 1b73235 Compare January 31, 2018 15:08

@benjaminbollen benjaminbollen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminbollen
benjaminbollen merged commit a7104c6 into develop Jan 31, 2018
@jasonklein jasonklein mentioned this pull request Feb 5, 2018
3 tasks
@jasonklein jasonklein modified the milestones: v0.9.2, v0.9.3 Mar 27, 2018
@benjaminbollen
benjaminbollen deleted the jasonbanks/gh91/pass-uuid-parameters branch June 4, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants