Unit test Cases for Revert Staking, Minting, Revert Redemption, Revert Unstaking - #74
Conversation
benjaminbollen
left a comment
benjaminbollen
left a comment
There was a problem hiding this comment.
Please correct to BT (currently said to be BT but is BT Wei);
| // processed the unstaking, ie unstake has not been deleted | ||
| require(unstake.expirationHeight > 0); | ||
| require(unstake.expirationHeight <= block.number); | ||
| // require that the unstake has expired and that the redeemer has not |
There was a problem hiding this comment.
we will need to discuss a standard and then implement a Linter check in the CI (to be put in place); for now OK, but the editors fighting is really not clean on the origin repo
There was a problem hiding this comment.
Hey Ben, me, deepesh and abhay have synched are tab space to two. We can decide on which linter to use as we all use different editors for coding.
|
|
||
| var stakeAmountST = 1, | ||
| convertedAmountBT = (stakeAmountST*conversionRate), | ||
| redemptionAmountBT = 2, // How many Branded tokens to redeem |
There was a problem hiding this comment.
This is in BT Wei, not BT; please correct to BT
benjaminbollen
left a comment
benjaminbollen
left a comment
There was a problem hiding this comment.
Thanks; Let's create a ticket to do a full scan of all ST vs STWei corrections for the unit and integration tests
|
|
||
| var staker = accounts[0]; | ||
| var owner = accounts[1]; | ||
| var amountST = 126; |
There was a problem hiding this comment.
We should do full scan of unit tests of consistent use of ST vs STWei (UT vs UTWei, BT vs BTWei)
4 participants
No description provided.