On failed and reverted redemption, allow reuse of nonce - #59
Merged
Conversation
…ts are incurred when reusing nonce, and monotonic nonce is kept on OpenSTValue; allows for retry upon failed and reverted redemption
benjaminbollen
force-pushed
the
benjaminbollen/gh56/revertnonce
branch
from
December 12, 2017 15:17
edd747d to
a324200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56
Original proposal was to revert back the nonce on the utility chain (as monotonic nonce is kept on value chain); but the more elegant solution is to loosen the requirement on
redeemandredeemSTPonOpenSTUtility;as such a redeemer could redeem multiple times with the same nonce, but only one could be used to unstake, and as a result the redeemer only incurs a cost of handing over utility tokens on redeeming multiple times;
however if a redemption attempt fails, and is reverted, the redeemer can reuse the same nonce to retry the redemption.
addressed unit tests for this change in requirements.