Unit Tests for Registrar and Protocol contracts - #35
Merged
Conversation
added 4 commits
November 29, 2017 14:33
benjaminbollen
approved these changes
Dec 5, 2017
| /// ProcessRedeeming | ||
| /// BrandedToken | ||
| /// fails to process if redemptionIntentHash is empty | ||
| /// fails to process if msg.sender != redeemer |
Contributor
There was a problem hiding this comment.
this will be changed, like I did for ProcessStaking with the fallback option; Good for this PR; will then complete in #26 where we implement the fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides (additional) unit testing of
Registrar.sol,OpenSTValue.sol, andOpenSTUtility.sol.There are 3 failing tests. In
OpenSTValue.sol, 2 tests are failing due to the math converting from BT to ST; see #21 . InOpenSTUtility.sol, there is one failing test due to a mistyped argument for a function. This test should pass after the merging of #33.