Fix Bash syntax

Test -v should be followed by the variable name without $, otherwise the
variable is expanded first.

This bug made the import use the planet_osm_nodes table in the database
but the diff updates use the flatnodes file. As a consequence, diff
updates removed updated ways from the database if their nodes have not
been changed since the first import.

Author: Nakaner

ansible/roles/tileserver/files/scripts/import.sh

@@ -34,7 +34,7 @@ echo "[2/3] Filtering data extract"
 $OSMIUM tags-filter -o $PLANET_FILTERED $PLANET_FILE $OSMIUM_FILTER_EXPR
 
 echo "[3/3] Import data into database"
-if [[ -v "$OSM2PGSQL_FLATNODES" ]]; then
+if [[ -v "OSM2PGSQL_FLATNODES" ]]; then
     FLATNODES_OPTION="--flat-node $FLATNODES_FILE"
 else
     FLATNODES_OPTION=""

ansible/roles/tileserver/files/scripts/update_osm.sh

@@ -44,7 +44,7 @@ function apply_diff_database {
     else
         FLATNODES_OPTION=""
     fi
-    if [[ -v "$OSM2PGSQL_NUMBER_PROCESSES" ]]; then
+    if [[ -v "OSM2PGSQL_NUMBER_PROCESSES" ]]; then
         NUMBER_PROCESSES_OPTION="--number-processes $OSM2PGSQL_NUMBER_PROCESSES"
     else
         NUMBER_PROCESSES_OPTION=""