Skip to content

Commit de4b7d5

Browse files
committed
Docker: mkdir -p the package js-component dir before syncing dist (fresh-clone fix)
In a fresh clone openms_insight/js-component/ does not exist (it only ever held the gitignored dist/), so cp had no parent dir and the build failed. mkdir -p it first. Validated end-to-end against a fresh clone of the branch: clone -> npm build -> sync -> pip wheel produces a wheel bundling the Vue dist (7 files incl. index.js).
1 parent dcd9b49 commit de4b7d5

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ ADD https://api.github.com/repos/t0mdavid-m/openms-insight/git/refs/heads/${INSI
9090
RUN git clone -b ${INSIGHT_BRANCH} --single-branch ${INSIGHT_REPO} /openms-insight
9191
WORKDIR /openms-insight/js-component
9292
RUN npm install && npm run build
93-
RUN rm -rf /openms-insight/openms_insight/js-component/dist \
93+
RUN mkdir -p /openms-insight/openms_insight/js-component \
94+
&& rm -rf /openms-insight/openms_insight/js-component/dist \
9495
&& cp -r /openms-insight/js-component/dist /openms-insight/openms_insight/js-component/dist \
9596
&& rm -rf /openms-insight/js-component/node_modules
9697

Dockerfile.arm

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ ADD https://api.github.com/repos/t0mdavid-m/openms-insight/git/refs/heads/${INSI
8585
RUN git clone -b ${INSIGHT_BRANCH} --single-branch ${INSIGHT_REPO} /openms-insight
8686
WORKDIR /openms-insight/js-component
8787
RUN npm install && npm run build
88-
RUN rm -rf /openms-insight/openms_insight/js-component/dist \
88+
RUN mkdir -p /openms-insight/openms_insight/js-component \
89+
&& rm -rf /openms-insight/openms_insight/js-component/dist \
8990
&& cp -r /openms-insight/js-component/dist /openms-insight/openms_insight/js-component/dist \
9091
&& rm -rf /openms-insight/js-component/node_modules
9192

0 commit comments

Comments
 (0)