Skip to content

Commit 07765cb

Browse files
authored
Merge pull request #524 from OpenBioSim/fix_523
2 parents 329cf76 + 10e0835 commit 07765cb

3 files changed

Lines changed: 19 additions & 17 deletions

File tree

pixi.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ loguru = "*"
1313
lomap2 = "*"
1414
networkx = "*"
1515
nglview = "*"
16-
openff-interchange-base = "*"
16+
openff-interchange-base = ">=0.5.0"
1717
openff-toolkit-base = "*"
1818
parmed = "*"
1919
pyarrow = "*"

recipes/biosimspace/recipe.yaml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,14 @@ requirements:
2727
- lomap2
2828
- networkx
2929
- nglview
30-
- openff-interchange-base
30+
- if: match(python, ">=3.11")
31+
then:
32+
- openff-interchange-base >=0.5.0
33+
else:
34+
- openff-interchange-base
35+
- if: match(python, "<3.11")
36+
then:
37+
- setuptools <82
3138
- openff-toolkit-base
3239
- parmed
3340
- pyarrow
@@ -61,6 +68,9 @@ tests:
6168
requirements:
6269
run:
6370
- pytest
71+
- if: match(python, "<3.11")
72+
then:
73+
- setuptools <82
6474
- if: linux and x86_64
6575
then:
6676
- ambertools

tests/Align/test_align.py

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -829,6 +829,7 @@ def test_ion_merge(system):
829829
),
830830
],
831831
)
832+
@pytest.mark.skipif(has_openff is False, reason="Requires OpenFF to be installed.")
832833
def test_ring_opening_and_size_change(ligands, mapping):
833834
# These perturbations involve ring formation (acyclic atoms in mol0 become
834835
# ring members in mol1) combined with ring size changes in the existing
@@ -946,14 +947,6 @@ def test_ring_breaking_intrascale():
946947
assert len(omm_nopatch.changed_exceptions()) == len(ref_exceptions)
947948

948949

949-
@pytest.mark.skipif(
950-
not has_antechamber or not has_tleap,
951-
reason="Requires antechamber and tLEaP to be installed.",
952-
)
953-
@pytest.mark.skipif(
954-
not has_openff,
955-
reason="Requires OpenFF to be installed.",
956-
)
957950
def test_ring_breaking_intrascale_m338():
958951
"""
959952
Test that ring-breaking merges produce correct intrascale matrices for a
@@ -1008,12 +1001,8 @@ def test_ring_breaking_intrascale_m338():
10081001
38: 36,
10091002
}
10101003

1011-
mol0 = BSS.Parameters.openff_unconstrained_2_2_1(
1012-
BSS.IO.readMolecules(f"{url}/int1.sdf")[0]
1013-
).getMolecule()
1014-
mol1 = BSS.Parameters.openff_unconstrained_2_2_1(
1015-
BSS.IO.readMolecules(f"{url}/m338.sdf")[0]
1016-
).getMolecule()
1004+
mol0 = BSS.IO.readMolecules([f"{url}/int1.prm7", f"{url}/int1.rst7"])[0]
1005+
mol1 = BSS.IO.readMolecules([f"{url}/m338.prm7", f"{url}/m338.rst7"])[0]
10171006

10181007
mol0_aligned = BSS.Align.rmsdAlign(mol0, mol1, mapping)
10191008
merged = BSS.Align.merge(
@@ -1210,7 +1199,10 @@ def test_ring_breaking_cross_bond_cleanup():
12101199
for p in sire_mol.property(f"dihedral{suffix}").potentials():
12111200
j = mol_info.atom_idx(p.atom1()).value()
12121201
k = mol_info.atom_idx(p.atom2()).value()
1213-
assert (min(j, k), max(j, k)) not in changing, (
1202+
assert (
1203+
min(j, k),
1204+
max(j, k),
1205+
) not in changing, (
12141206
f"dihedral{suffix} central bond ({j},{k}) spans absent bond"
12151207
)
12161208

0 commit comments

Comments
 (0)