Bug fix : Fix error return when SET NX/XX command fails - #1343
Merged
Conversation
Collaborator
|
thanks! |
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in the process of executing the SET command.
When the
SETcommand contains parameters:NXorXXand the execution fails, the wrong RESP information will be written to the i/o buffer:*-1\r\n(Null Array), in fact, the correct return format should be:$-1\r\n(Null Bulk String), this wrong return will cause some Redis clients to generate some exceptions.