fix(evals): compute alarmCount from findings inside SuiteHeaderCard

No template ever populated config.alarmCount, so the 'X alarms' badge
never rendered. Derive the count from computeFindings() using the
suite's current snapshot ids so the badge self-wires from data.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: NickB03

components/evals/dashboard-v2/dashboard.test.tsx

@@ -218,6 +218,26 @@ describe('EvalsDashboardV2', () => {
     expect(expanded[0].getAttribute('data-feed-row-id')).toBe('traf-latest')
   })
 
+  it('renders an alarm-count badge on the traffic-monitor suite header when findings exist', () => {
+    // Scenario: traffic-monitor latest has a ≥5pt drop on response_quality vs
+    // previous. computeFindings emits one 'drop' finding attached to latest.id.
+    // TEMPLATE_B's traf-header sets showAlarmCount: true, so the badge should
+    // self-wire and render "1 alarm".
+    const data = makeData()
+    data.trafficMonitor.previous!.evaluatorScores = {
+      ...data.trafficMonitor.previous!.evaluatorScores,
+      response_quality: 0.92
+    }
+    data.trafficMonitor.latest!.evaluatorScores = {
+      ...data.trafficMonitor.latest!.evaluatorScores,
+      response_quality: 0.8
+    }
+
+    render(<EvalsDashboardV2 data={data} initialLayout="b" />)
+
+    expect(screen.getByText(/1 alarm/i)).toBeInTheDocument()
+  })
+
   it('getTemplate returns a template for every template id', () => {
     for (const id of ['a', 'b', 'c'] as const) {
       const tpl = getTemplate(id)

components/evals/widgets/suite-header-card.tsx

@@ -3,6 +3,7 @@
 import { formatDistanceToNow } from 'date-fns'
 import { Activity, BarChart3 } from 'lucide-react'
 
+import { computeFindings } from '@/lib/evals/helpers/findings'
 import type { HealthState } from '@/lib/evals/helpers/health-state'
 import {
   healthForScore,
@@ -29,7 +30,6 @@ type Config = {
   showChips?: boolean
   showSparkline?: boolean
   showAlarmCount?: boolean
-  alarmCount?: number
 }
 
 export function SuiteHeaderCard({
@@ -51,6 +51,14 @@ export function SuiteHeaderCard({
     suiteKey === 'capability' ? 0.9 : 0.85,
     suiteKey === 'capability' ? 0.75 : 0.7
   )
+  const alarmCount = config.showAlarmCount
+    ? computeFindings(data).filter(
+        f =>
+          f.severity !== 'improvement' &&
+          (f.snapshotId === latest.id ||
+            f.snapshotId === (suite.previous?.id ?? ''))
+      ).length
+    : 0
 
   if (config.variant === 'rail') {
     return (
@@ -100,11 +108,9 @@ export function SuiteHeaderCard({
                 {config.cadence}
               </Badge>
             ) : null}
-            {config.showAlarmCount &&
-            config.alarmCount &&
-            config.alarmCount > 0 ? (
+            {alarmCount > 0 ? (
               <Badge variant="destructive" className="ml-auto">
-                {config.alarmCount} alarm{config.alarmCount > 1 ? 's' : ''}
+                {alarmCount} alarm{alarmCount > 1 ? 's' : ''}
               </Badge>
             ) : null}
           </div>