Skip to content

Bug fix for callbacks - #83

Merged
drazvan merged 3 commits into
NVIDIA-NeMo:mainfrom
Siraj-Aizlewood:Bug-fix-for-Callbacks
Jul 21, 2023
Merged

Bug fix for callbacks#83
drazvan merged 3 commits into
NVIDIA-NeMo:mainfrom
Siraj-Aizlewood:Bug-fix-for-Callbacks

Conversation

@Siraj-Aizlewood

Copy link
Copy Markdown

See relevant LangChain Pull Request:

langchain-ai/langchain#6858

Was getting the following error:

image

Fixed by by providing tags = [] and inheritable_tags = [] arguments in callbacks.py, giving:

logging_callback_manager_for_chain = AsyncCallbackManagerForChainRun(
    run_id=uuid.uuid4(),
    parent_run_id=None,
    handlers=handlers,
    inheritable_handlers=handlers,
    tags=[],
    inheritable_tags=[],
)

Siraj R Aizlewood added 3 commits July 21, 2023 10:51
Was getting a

"BaseRunManager.__init__() missing 2 required keyword-only arugments: 'tags' and 'inheritable_tags'"

error.

AsyncCallbackManagerForChainRun inherits AsyncRunManager which inherits BaseRunManager which requires tags and inheritable_tags arguments. We can set these to empty lists.
Was getting a

"BaseRunManager.__init__() missing 2 required keyword-only arugments: 'tags' and 'inheritable_tags'"

error.

AsyncCallbackManagerForChainRun inherits AsyncRunManager which inherits BaseRunManager which requires tags and inheritable_tags arguments. We can set these to empty lists.
@drazvan

drazvan commented Jul 21, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the fix @Siraj-Aizlewood!

@drazvan
drazvan merged commit 46b5bfa into NVIDIA-NeMo:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants