refactor(llm): remove LLMs isolation for actions - #1408
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
trebedea
self-requested a review
September 23, 2025 09:29
4 tasks
Removes the logic for creating isolated LLM instances for actions that require an 'llm' parameter in `LLMRails`. This includes deleting the `_create_isolated_llms_for_actions`, `_detect_llm_requiring_actions`, `_get_action_function`, and `_create_action_llm_copy` methods, as well as removing their invocation from the class initialization. Also deletes all related tests, including unit, integration, and e2e tests for LLM isolation and model_kwargs handling. This simplifies the codebase and test suite by eliminating support for per-action LLM isolation.
Pouyanpi
force-pushed
the
refactor/remove-llm-isolation
branch
from
September 23, 2025 16:16
e29e866 to
b8d3ab8
Compare
Pouyanpi
changed the title
Pouyanpi
added a commit
that referenced
this pull request
Oct 1, 2025
* refactor(llm): remove isolated LLMs for actions Removes the logic for creating isolated LLM instances for actions that require an 'llm' parameter in `LLMRails`. This includes deleting the `_create_isolated_llms_for_actions`, `_detect_llm_requiring_actions`, `_get_action_function`, and `_create_action_llm_copy` methods, as well as removing their invocation from the class initialization. Also deletes all related tests, including unit, integration, and e2e tests for LLM isolation and model_kwargs handling. This simplifies the codebase and test suite by eliminating support for per-action LLM isolation. * Revert tests/utils.py to state before #1336
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
* refactor(llm): remove isolated LLMs for actions Removes the logic for creating isolated LLM instances for actions that require an 'llm' parameter in `LLMRails`. This includes deleting the `_create_isolated_llms_for_actions`, `_detect_llm_requiring_actions`, `_get_action_function`, and `_create_action_llm_copy` methods, as well as removing their invocation from the class initialization. Also deletes all related tests, including unit, integration, and e2e tests for LLM isolation and model_kwargs handling. This simplifies the codebase and test suite by eliminating support for per-action LLM isolation. * Revert tests/utils.py to state before #1336
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
* refactor(llm): remove isolated LLMs for actions Removes the logic for creating isolated LLM instances for actions that require an 'llm' parameter in `LLMRails`. This includes deleting the `_create_isolated_llms_for_actions`, `_detect_llm_requiring_actions`, `_get_action_function`, and `_create_action_llm_copy` methods, as well as removing their invocation from the class initialization. Also deletes all related tests, including unit, integration, and e2e tests for LLM isolation and model_kwargs handling. This simplifies the codebase and test suite by eliminating support for per-action LLM isolation. * Revert tests/utils.py to state before #1336
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 14, 2025
* refactor(llm): remove isolated LLMs for actions Removes the logic for creating isolated LLM instances for actions that require an 'llm' parameter in `LLMRails`. This includes deleting the `_create_isolated_llms_for_actions`, `_detect_llm_requiring_actions`, `_get_action_function`, and `_create_action_llm_copy` methods, as well as removing their invocation from the class initialization. Also deletes all related tests, including unit, integration, and e2e tests for LLM isolation and model_kwargs handling. This simplifies the codebase and test suite by eliminating support for per-action LLM isolation. * Revert tests/utils.py to state before #1336
tgasser-nv
pushed a commit
that referenced
this pull request
Oct 28, 2025
* refactor(llm): remove isolated LLMs for actions Removes the logic for creating isolated LLM instances for actions that require an 'llm' parameter in `LLMRails`. This includes deleting the `_create_isolated_llms_for_actions`, `_detect_llm_requiring_actions`, `_get_action_function`, and `_create_action_llm_copy` methods, as well as removing their invocation from the class initialization. Also deletes all related tests, including unit, integration, and e2e tests for LLM isolation and model_kwargs handling. This simplifies the codebase and test suite by eliminating support for per-action LLM isolation. * Revert tests/utils.py to state before #1336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the logic for creating isolated LLM instances for actions that
require an 'llm' parameter in
LLMRails. This includes deleting the_create_isolated_llms_for_actions,_detect_llm_requiring_actions,_get_action_function, and_create_action_llm_copymethods, as wellas removing their invocation from the class initialization.
Also deletes all related tests, including unit, integration, and e2e
tests for LLM isolation and model_kwargs handling. This simplifies the
codebase and test suite by eliminating support for per-action LLM
isolation.