chore(types): Type-clean kb/ (1 error) - #1385
Merged
Merged
Conversation
19 tasks
trebedea
approved these changes
Sep 11, 2025
Pouyanpi
reviewed
Sep 16, 2025
tgasser-nv
changed the base branch from
chore/type-clean-guardrails
to
develop
September 22, 2025 21:30
tgasser-nv
marked this pull request as draft
October 13, 2025 13:59
Collaborator
Author
|
Converting to draft while I rebase on the latest changes to develop. |
tgasser-nv
force-pushed
the
chore/type-clean-kb
branch
from
October 14, 2025 20:29
5882d52 to
673aaf2
Compare
Contributor
Documentation preview |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
tgasser-nv
marked this pull request as ready for review
October 14, 2025 20:50
Collaborator
Author
tgasser-nv
force-pushed
the
chore/type-clean-kb
branch
from
October 15, 2025 14:40
6d22afd to
03ba055
Compare
Pouyanpi
pushed a commit
that referenced
this pull request
Oct 28, 2025
* Check for None before saving basic_index embeddings * Add nemoguardrails/kb to the pyright pre-commit list
tgasser-nv
added a commit
that referenced
this pull request
Oct 28, 2025
* Check for None before saving basic_index embeddings * Add nemoguardrails/kb to the pyright pre-commit list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleaned the kb/ directory's single Type error.
Test Plan
Type-checking
$ poetry run pre-commit run --all-files check yaml...............................................................Passed fix end of files.........................................................Passed trim trailing whitespace.................................................Passed isort (python)...........................................................Passed black....................................................................Passed Insert license in comments...............................................Passed pyright..................................................................PassedUnit-tests
Local CLI check
Checklist