docs: clarify purpose of model parameters field in configuration guide - #1181
Merged
Merged
Conversation
Fixes NVIDIA-NeMo#1124 Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
Contributor
Documentation preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1181 +/- ##
========================================
Coverage 68.24% 68.24%
========================================
Files 161 161
Lines 15938 15938
========================================
Hits 10877 10877
Misses 5061 5061
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
trebedea
approved these changes
May 8, 2025
Pouyanpi
approved these changes
May 9, 2025
Pouyanpi
left a comment
Pouyanpi
left a comment
Collaborator
There was a problem hiding this comment.
Thank you Mike for adding this! Looks good 👍🏻
Pouyanpi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify the purpose of the
models.model.parametersfield.Related Issue(s)
Fixes #1124
Checklist