fix: use ValueError in TaskPrompt to resolve TypeError raised by Pydantic - #1132
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the use of Pydantic’s ValidationError with ValueError in the TaskPrompt root_validator to resolve a previously raised TypeError during validation.
- Switch exception type in TaskPrompt from ValidationError to ValueError.
- Add tests to verify TaskPrompt validation logic.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/rails/llm/test_config.py | Tests for TaskPrompt now expect a validation error; however, the exception type in the PR has changed. |
| nemoguardrails/rails/llm/config.py | Updated TaskPrompt.check_fields to raise ValueError instead of ValidationError. |
tgasser-nv
approved these changes
Apr 22, 2025
tgasser-nv
left a comment
tgasser-nv
left a comment
Collaborator
There was a problem hiding this comment.
LGTM thanks for adding the tests
Added `ge=1` validation to `max_length` and `max_tokens` fields in the TaskPrompt class to ensure values are greater than or equal to 1.
Replaced the use of Pydantic's ValidationError with ValueError in the TaskPrompt class's root_validator. This resolves a TypeError caused by incorrect instantiation of ValidationError during validation.
Pouyanpi
force-pushed
the
fix/config-task-prompt
branch
from
April 23, 2025 07:27
33ff9f7 to
81236d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced the use of Pydantic's
ValidationErrorwithValueErrorin theTaskPromptclass'sroot_validator. This resolves aTypeErrorcaused by incorrect instantiation ofValidationErrorduring validation.related to #1111