Skip to content

fix: enable output rails streaming explicitly - #1045

Merged
Pouyanpi merged 2 commits into
developfrom
fix/output-rails-streaming-activation
Mar 21, 2025
Merged

fix: enable output rails streaming explicitly#1045
Pouyanpi merged 2 commits into
developfrom
fix/output-rails-streaming-activation

Conversation

@Pouyanpi

Copy link
Copy Markdown
Collaborator

Refactored the conditional checks to enable output streaming configuration based on the self.config.rails.output.streaming.enabled flag. This change ensures that the streaming handler is correctly utilized when output streaming is enabled in the configuration.

Refactored the conditional checks to enable output streaming configuration based on the `self.config.rails.output.streaming.enabled` flag. This change ensures that the streaming handler is correctly utilized when output streaming is enabled in the configuration.
@Pouyanpi
Pouyanpi requested a review from trebedea March 14, 2025 14:54
@Pouyanpi Pouyanpi self-assigned this Mar 14, 2025
@trebedea

Copy link
Copy Markdown
Member

Looks good.
@Pouyanpi - it would be nice if we could have a test if future changes break the correct behavior. If it's not simple to add it, we can merge without it.

@Pouyanpi

Copy link
Copy Markdown
Collaborator Author

@trebedea tests added 👍🏻

@Pouyanpi Pouyanpi added this to the v0.13.0 milestone Mar 21, 2025
@Pouyanpi
Pouyanpi merged commit 9038b96 into develop Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants