Booking reference generation behind feature flag

Author: jsed-nhs

src/api/Nhs.Appointments.Core/BookingWriteService.cs

@@ -1,8 +1,8 @@
 using Newtonsoft.Json.Linq;
 using Nhs.Appointments.Core.Concurrency;
+using Nhs.Appointments.Core.Features;
 using Nhs.Appointments.Core.Messaging;
 using Nhs.Appointments.Core.Messaging.Events;
-using Nhs.Appointments.Core.ReferenceNumber;
 using Nhs.Appointments.Core.ReferenceNumber.V1;
 using Nhs.Appointments.Core.ReferenceNumber.V2;
 
@@ -51,7 +51,8 @@ public class BookingWriteService(
     IBookingAvailabilityStateService bookingAvailabilityStateService,
     IBookingEventFactory eventFactory,
     IMessageBus bus,
-    TimeProvider time) : IBookingWriteService
+    TimeProvider time,
+    IFeatureToggleHelper featureToggleHelper) : IBookingWriteService
 {
     private static readonly ContactItemType[] ValidNotificationTypes =
         [ContactItemType.Email, ContactItemType.Phone];
@@ -74,10 +75,16 @@ public class BookingWriteService(
         }
 
         booking.Created = time.GetUtcNow();
+
+        if (await featureToggleHelper.IsFeatureEnabled(Flags.BookingReferenceV2))
+        {
+            booking.Reference = await referenceNumberProviderV2.GetReferenceNumber();
+        }
+        else
+        {
+            booking.Reference = await referenceNumberProviderV1.GetReferenceNumber(booking.Site);
+        }
 
-        booking.Reference = await referenceNumberProviderV1.GetReferenceNumber(booking.Site);
-        
-        booking.Reference = await referenceNumberProviderV2.GetReferenceNumber();
         booking.ReminderSent = false;
         booking.AvailabilityStatus = AvailabilityStatus.Supported;
         await bookingDocumentStore.InsertAsync(booking);

tests/Nhs.Appointments.Core.UnitTests/BookingWriteServiceTests.cs

@@ -1,4 +1,5 @@
 using Nhs.Appointments.Core.Concurrency;
+using Nhs.Appointments.Core.Features;
 using Nhs.Appointments.Core.Messaging;
 using Nhs.Appointments.Core.Messaging.Events;
 using Nhs.Appointments.Core.ReferenceNumber;
@@ -21,6 +22,8 @@ public class BookingWriteServiceTests
         private readonly Mock<IReferenceNumberProvider> _referenceNumberProviderV1 = new();
         private readonly Mock<IProvider> _referenceNumberProviderV2 = new();
 
+        private readonly Mock<IFeatureToggleHelper> _featureToggleHelper = new();
+        
         private readonly Mock<ISiteLeaseManager> _siteLeaseManager = new();
         private BookingWriteService _sut;
 
@@ -35,7 +38,8 @@ public BookingWriteServiceTests()
                 _bookingAvailabilityStateService.Object,
                 new EventFactory(),
                 _messageBus.Object,
-                TimeProvider.System);
+                TimeProvider.System,
+                _featureToggleHelper.Object);
         }
 
         [Fact]
@@ -67,7 +71,7 @@ public async Task MakeBooking_AcquiresLock_WhenBooking()
                 _referenceNumberProviderV1.Object,
                 _referenceNumberProviderV2.Object,
                 leaseManager, new BookingAvailabilityStateService(availabilityQueryService, bookingQueryService),
-                new EventFactory(), _messageBus.Object, TimeProvider.System);
+                new EventFactory(), _messageBus.Object, TimeProvider.System, _featureToggleHelper.Object);
 
             var task = Task.Run(() => bookingService.MakeBooking(booking));
             await Task.Delay(100);