Add obsolete flags to V1 code so that it is marked for deletion in time

Author: jsed-nhs

src/api/Nhs.Appointments.Core/BookingWriteService.cs

@@ -82,7 +82,9 @@ public class BookingWriteService(
         }
         else
         {
+            #pragma warning disable CS0618 // Code to be removed once Flags.BookingReferenceV2 is fully enabled
             booking.Reference = await referenceNumberProviderV1.GetReferenceNumber(booking.Site);
+            #pragma warning restore CS0618 // Code to be removed once Flags.BookingReferenceV2 is fully enabled
         }
 
         booking.ReminderSent = false;

src/api/Nhs.Appointments.Core/ReferenceNumber/V1/Provider.cs

@@ -2,40 +2,36 @@ namespace Nhs.Appointments.Core.ReferenceNumber.V1;
 
 public interface IReferenceNumberProvider
 {
+    [Obsolete("Deprecated in favor of ReferenceNumber.V2.IProvider.GetReferenceNumber")]
     Task<string> GetReferenceNumber(string siteId);
 }
 
-public class ReferenceNumberProvider : IReferenceNumberProvider
+[Obsolete("Deprecated in favor of ReferenceNumber.V2.Provider")]
+public class ReferenceNumberProvider(
+    ISiteStore siteStore,
+    IReferenceNumberDocumentStore referenceNumberDocumentStore,
+    TimeProvider timeProvider)
+    : IReferenceNumberProvider
 {
-    private readonly ISiteStore _siteStore;
-    private readonly IReferenceNumberDocumentStore _referenceNumberDocumentStore;
-    private readonly TimeProvider _timeProvider;
-    public ReferenceNumberProvider(
-        ISiteStore siteStore,
-        IReferenceNumberDocumentStore referenceNumberDocumentStore,
-        TimeProvider timeProvider)
-    {
-        _siteStore = siteStore;
-        _referenceNumberDocumentStore = referenceNumberDocumentStore;
-        _timeProvider = timeProvider;
-    }
+    [Obsolete("Deprecated in favor of ReferenceNumber.V2.Provider.GetReferenceNumber")]
     public async Task<string> GetReferenceNumber(string siteId)
     {        
-        var referenceGroup = await _siteStore.GetReferenceNumberGroup(siteId);
+        var referenceGroup = await siteStore.GetReferenceNumberGroup(siteId);
         if (referenceGroup == 0)
         {
-            referenceGroup = await _referenceNumberDocumentStore.AssignReferenceGroup();
-            await _siteStore.AssignPrefix(siteId, referenceGroup);
+            referenceGroup = await referenceNumberDocumentStore.AssignReferenceGroup();
+            await siteStore.AssignPrefix(siteId, referenceGroup);
         }
 
-        var sequence = await _referenceNumberDocumentStore.GetNextSequenceNumber(referenceGroup);
-        var now = _timeProvider.GetUtcNow();
+        var sequence = await referenceNumberDocumentStore.GetNextSequenceNumber(referenceGroup);
+        var now = timeProvider.GetUtcNow();
         var rng = now.Day + now.Second;
 
         return $"{referenceGroup:00}-{rng:00}-{sequence:000000}";
     }
 }
 
+[Obsolete("Deprecated in favor of ReferenceNumber.V2.IBookingReferenceDocumentStore")]
 public interface IReferenceNumberDocumentStore
 {
     Task<int> AssignReferenceGroup();

tests/Nhs.Appointments.Core.UnitTests/ReferenceNumber/V1/ReferenceNumberProviderTests.cs

@@ -1,4 +1,5 @@
 using Nhs.Appointments.Core.ReferenceNumber.V1;
+#pragma warning disable CS0618 // Code to be removed once Flags.BookingReferenceV2 is fully enabled
 
 namespace Nhs.Appointments.Core.UnitTests.ReferenceNumber.V1;