Update invalidated patients from PDS

This should improve dealing with cases where a patient was invalidated
without an NHS number, but they now have an NHS number.

There are currently 75 patients in production marked as invalid. We
first want to check whether any of these are now superseded, and
whether, if we were to refresh their details from PDS, we would get new
patient details for them. If this is the case then we should ensure
that invalidated patients are also updated from PDS as part of the
nightly background job.

Jira-Issue: MAV-1962

Author: thomasleese

app/jobs/patient_update_from_pds_job.rb

@@ -8,8 +8,6 @@ class PatientUpdateFromPDSJob < ApplicationJob
   def perform(patient)
     raise MissingNHSNumber if patient.nhs_number.nil?
 
-    return if patient.invalidated?
-
     pds_patient = PDS::Patient.find(patient.nhs_number)
 
     if pds_patient.nhs_number != patient.nhs_number

spec/jobs/patient_update_from_pds_job_spec.rb

@@ -13,15 +13,6 @@
     end
   end
 
-  context "invalidated patient" do
-    let!(:patient) { create(:patient, :invalidated) }
-
-    it "doesn't update the patient" do
-      expect(patient).not_to receive(:update_from_pds!)
-      perform_now
-    end
-  end
-
   context "with an NHS number" do
     before { create(:gp_practice, ods_code: "Y12345") }
 
@@ -61,6 +52,17 @@
         )
       end
 
+      context "when the patient is invalidated" do
+        let!(:patient) do
+          create(:patient, :invalidated, nhs_number: "9000000009")
+        end
+
+        it "updates the patient details from PDS" do
+          expect(patient).to receive(:update_from_pds!)
+          perform_now
+        end
+      end
+
       context "when the NHS number for the patient has changed" do
         let!(:patient) { create(:patient, nhs_number: "0123456789") }