Allow GovukNotifyPersonalisation to handle session = nil

This fixes a bug for templates which don't need to reference a
session.

Author: alistair-white-horne-tng

app/lib/govuk_notify_personalisation.rb

@@ -107,6 +107,8 @@ def not_catch_up
   end
 
   def consent_deadline
+    return nil if session.nil?
+
     next_date = session.future_dates.first
 
     close_consent_at =
@@ -117,6 +119,7 @@ def consent_deadline
 
   def consent_link
     return nil if session.nil? || programmes.empty?
+
     host +
       start_parent_interface_consent_forms_path(
         session,
@@ -173,41 +176,41 @@ def location_name
     if vaccination_record
       vaccination_record_location(vaccination_record)
     else
-      session.location.name
+      session&.location&.name
     end
   end
 
   def next_or_today_session_date
-    session.next_date(include_today: true)&.to_fs(:short_day_of_week)
+    session&.next_date(include_today: true)&.to_fs(:short_day_of_week)
   end
 
   def next_or_today_session_dates
     session
-      .today_or_future_dates
-      .map { it.to_fs(:short_day_of_week) }
-      .to_sentence
+      &.today_or_future_dates
+      &.map { it.to_fs(:short_day_of_week) }
+      &.to_sentence
   end
 
   def next_or_today_session_dates_or
     session
-      .today_or_future_dates
-      .map { it.to_fs(:short_day_of_week) }
-      .to_sentence(last_word_connector: ", or ", two_words_connector: " or ")
+      &.today_or_future_dates
+      &.map { it.to_fs(:short_day_of_week) }
+      &.to_sentence(last_word_connector: ", or ", two_words_connector: " or ")
   end
 
   def next_session_date
-    session.next_date(include_today: false)&.to_fs(:short_day_of_week)
+    session&.next_date(include_today: false)&.to_fs(:short_day_of_week)
   end
 
   def next_session_dates
-    session.future_dates.map { it.to_fs(:short_day_of_week) }.to_sentence
+    session&.future_dates&.map { it.to_fs(:short_day_of_week) }&.to_sentence
   end
 
   def next_session_dates_or
     session
-      .future_dates
-      .map { it.to_fs(:short_day_of_week) }
-      .to_sentence(last_word_connector: ", or ", two_words_connector: " or ")
+      &.future_dates
+      &.map { it.to_fs(:short_day_of_week) }
+      &.to_sentence(last_word_connector: ", or ", two_words_connector: " or ")
   end
 
   def outcome_administered
@@ -263,6 +266,8 @@ def show_additional_instructions
   end
 
   def subsequent_session_dates_offered_message
+    return nil if session.nil?
+
     dates = session.future_dates.drop(1)
     return "" if dates.empty?
 
@@ -304,7 +309,10 @@ def talk_to_your_child_message
     ].join("\n\n")
   end
 
-  delegate :privacy_notice_url, :privacy_policy_url, to: :team, prefix: true
+  delegate :privacy_notice_url,
+           :privacy_policy_url,
+           to: :team,
+           prefix: true
 
   def today_or_date_of_vaccination
     return if vaccination_record.nil?

spec/lib/govuk_notify_personalisation_spec.rb

@@ -513,4 +513,13 @@
       end
     end
   end
+
+  context "with session nil" do
+    let(:session) { nil }
+    let(:consent) { create(:consent, patient:) }
+
+    it "doesn't throw an error" do
+      expect { to_h }.not_to raise_error
+    end
+  end
 end