Merge pull request #5126 from nhsuk/revert-changeset-fallback

Change ProcessPatientChangesetJob to accept changeset id (part 2 of 2)

Author: misaka

app/jobs/process_patient_changeset_job.rb

@@ -4,13 +4,7 @@ class ProcessPatientChangesetJob < ApplicationJob
   queue_as :imports
 
   def perform(patient_changeset_id)
-    patient_changeset =
-      if patient_changeset_id.is_a?(PatientChangeset)
-        patient_changeset_id
-      else
-        PatientChangeset.find(patient_changeset_id)
-      end
-
+    patient_changeset = PatientChangeset.find(patient_changeset_id)
     return if patient_changeset.processed?
 
     unique_nhs_number = get_unique_nhs_number(patient_changeset)

spec/jobs/process_patient_changeset_job_spec.rb

@@ -221,27 +221,5 @@
         }.not_to have_enqueued_job(CommitImportJob)
       end
     end
-
-    context "when passed a PatientChangeset object" do
-      let(:search_results) do
-        [
-          {
-            "step" => "no_fuzzy_with_history",
-            "result" => "one_match",
-            "nhs_number" => "9449306168",
-            "created_at" => Time.current.iso8601(3)
-          }
-        ]
-      end
-
-      it "processes the changeset correctly" do
-        described_class.perform_now(patient_changeset)
-
-        expect(patient_changeset.reload).to be_processed
-        expect(patient_changeset.child_attributes["nhs_number"]).to eq(
-          "9449306168"
-        )
-      end
-    end
   end
 end