Commit 0a95de7
Remove unused Cuprite-related code
The JavaScript driver for Capybara was being configured to use Cuprite to drive
a browser for JS-enabled specs. However, there are no such specs at the moment
and it's not obvious that there have ever been any.
When we added `js: true` to an existing feature spec and ran it, we saw an
exception, so it's not obvious that it was even working.
The feature specs currently use the default Capybara driver which is rack-test.
Since this doesn't drive a browser, it doesn't support screenshots, so we
removed the `capybara-screenshot` gem as well.
`Capybara.asset_host` is only relevant for browser-based specs and so it
doesn't need to be set any more.
The code that was checking for the browser binary by rescuing
`Ferrum::BinaryNotFoundError` is no longer needed, because Ferrum is the
lower-level gem used by Cuprite.
Currently if a JS-enabled spec is needed it's added to the e2e specs [1] which
use Python & Playwright. If we ever need to add JS-enabled specs to this repo,
it would probably make sense to use the Playwright driver for Capybara for
consistency with the e2e specs.
[1]: https://github.com/NHSDigital/manage-vaccinations-in-schools-testing/
Co-authored-by: Chris Lowis <chris.lowis@gofreerange.com>1 parent 25ad0b5 commit 0a95de7
3 files changed
Lines changed: 0 additions & 45 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
122 | 121 | | |
123 | | - | |
124 | 122 | | |
125 | 123 | | |
126 | 124 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | 240 | | |
244 | 241 | | |
245 | 242 | | |
246 | 243 | | |
247 | 244 | | |
248 | 245 | | |
249 | 246 | | |
250 | | - | |
251 | | - | |
252 | 247 | | |
253 | 248 | | |
254 | 249 | | |
| |||
271 | 266 | | |
272 | 267 | | |
273 | 268 | | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | 269 | | |
278 | 270 | | |
279 | 271 | | |
| |||
346 | 338 | | |
347 | 339 | | |
348 | 340 | | |
349 | | - | |
350 | | - | |
351 | | - | |
352 | | - | |
353 | | - | |
354 | | - | |
355 | 341 | | |
356 | 342 | | |
357 | 343 | | |
| |||
446 | 432 | | |
447 | 433 | | |
448 | 434 | | |
449 | | - | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | 435 | | |
454 | 436 | | |
455 | 437 | | |
| |||
945 | 927 | | |
946 | 928 | | |
947 | 929 | | |
948 | | - | |
949 | 930 | | |
950 | 931 | | |
951 | 932 | | |
952 | 933 | | |
953 | 934 | | |
954 | 935 | | |
955 | 936 | | |
956 | | - | |
957 | 937 | | |
958 | 938 | | |
959 | 939 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
112 | | - | |
113 | 111 | | |
114 | 112 | | |
115 | 113 | | |
116 | 114 | | |
117 | 115 | | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | 116 | | |
132 | 117 | | |
133 | 118 | | |
| |||
186 | 171 | | |
187 | 172 | | |
188 | 173 | | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | 174 | | |
198 | 175 | | |
199 | 176 | | |
| |||
0 commit comments