Skip to content

Commit ccb5f61

Browse files
NIAD-3137: Refactor to use IsEqualToIgnoringWhitespace
A quick refactor to use IsEqualToIgnoringWhitespace rather than helper method doing the same thing.
1 parent 0a606e4 commit ccb5f61

1 file changed

Lines changed: 18 additions & 20 deletions

File tree

service/src/test/java/uk/nhs/adaptors/gp2gp/ehr/mapper/EncounterComponentsMapperTest.java

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,8 @@ public void When_MappingEncounterComponents_Expect_ResourceMapped() {
227227

228228
System.out.println(mappedXml);
229229

230-
assertThat(removeLineEndingsAndWhiteSpace(mappedXml)).isEqualTo(removeLineEndingsAndWhiteSpace(expectedXml));
230+
assertThat(mappedXml)
231+
.isEqualToIgnoringWhitespace(expectedXml);
231232
}
232233

233234
@Test
@@ -238,7 +239,8 @@ public void When_MappingEncounterComponents_Expect_IgnoredResourceNotMapped() {
238239
var encounter = extractEncounter(bundle);
239240

240241
String mappedXml = encounterComponentsMapper.mapComponents(encounter);
241-
assertThat(removeLineEndingsAndWhiteSpace(mappedXml)).isEqualTo(removeLineEndingsAndWhiteSpace(expectedXml));
242+
assertThat(mappedXml)
243+
.isEqualToIgnoringWhitespace(expectedXml);
242244
}
243245

244246
@ParameterizedTest
@@ -307,7 +309,8 @@ public void When_MappingTopic_With_RelatedProblem_Expect_MappedToCode() {
307309

308310
String mappedXml = encounterComponentsMapper.mapComponents(encounter);
309311

310-
assertThat(removeLineEndingsAndWhiteSpace(mappedXml)).isEqualTo(removeLineEndingsAndWhiteSpace(expectedXml));
312+
assertThat(mappedXml)
313+
.isEqualToIgnoringWhitespace(expectedXml);
311314
}
312315

313316
@Test
@@ -321,7 +324,8 @@ public void When_MappingTopic_With_RelatedProblemAndNoTitle_Expect_MappedToCode(
321324

322325
String mappedXml = encounterComponentsMapper.mapComponents(encounter);
323326

324-
assertThat(removeLineEndingsAndWhiteSpace(mappedXml)).isEqualTo(removeLineEndingsAndWhiteSpace(expectedXml));
327+
assertThat(mappedXml)
328+
.isEqualToIgnoringWhitespace(expectedXml);
325329
}
326330

327331
@Test
@@ -332,7 +336,8 @@ public void When_MappingTopic_With_MissingDate_Expect_DateMappedFromEncounter()
332336

333337
String mappedXml = encounterComponentsMapper.mapComponents(encounter);
334338

335-
assertThat(removeLineEndingsAndWhiteSpace(mappedXml)).isEqualTo(removeLineEndingsAndWhiteSpace(expectedXml));
339+
assertThat(mappedXml)
340+
.isEqualToIgnoringWhitespace(expectedXml);
336341
}
337342

338343
@Test
@@ -346,7 +351,8 @@ public void When_MappingCategory_WithAndWithout_Title_Expect_BothCdsPresent() {
346351

347352
String mappedXml = encounterComponentsMapper.mapComponents(encounter);
348353

349-
assertThat(removeLineEndingsAndWhiteSpace(mappedXml)).isEqualTo(removeLineEndingsAndWhiteSpace(expectedXml));
354+
assertThat(mappedXml)
355+
.isEqualToIgnoringWhitespace(expectedXml);
350356
}
351357

352358
@Test
@@ -361,7 +367,8 @@ public void When_MappingTopic_WithAndWithout_Title_Expect_BothCdsPresent() {
361367

362368
String mappedXml = encounterComponentsMapper.mapComponents(encounter);
363369

364-
assertThat(removeLineEndingsAndWhiteSpace(mappedXml)).isEqualTo(removeLineEndingsAndWhiteSpace(expectedXml));
370+
assertThat(mappedXml)
371+
.isEqualToIgnoringWhitespace(expectedXml);
365372
}
366373

367374
@Test
@@ -372,7 +379,8 @@ public void When_MappingTopic_WithoutCategory_Expect_ComponentsMapped() {
372379

373380
String mappedXml = encounterComponentsMapper.mapComponents(encounter);
374381

375-
assertThat(removeLineEndingsAndWhiteSpace(mappedXml)).isEqualTo(removeLineEndingsAndWhiteSpace(expectedXml));
382+
assertThat(mappedXml)
383+
.isEqualToIgnoringWhitespace(expectedXml);
376384
}
377385

378386
@ParameterizedTest
@@ -386,7 +394,8 @@ public void When_MappingContainedResource_Expect_ResourcesMapped(String inputBun
386394

387395
System.out.println(mappedXml);
388396

389-
assertThat(removeLineEndingsAndWhiteSpace(mappedXml)).isEqualTo(removeLineEndingsAndWhiteSpace(expectedXml));
397+
assertThat(mappedXml)
398+
.isEqualToIgnoringWhitespace(expectedXml);
390399
}
391400

392401
@Test
@@ -469,17 +478,6 @@ private static Stream<Arguments> containedResourceMappingArguments() {
469478
);
470479
}
471480

472-
private String removeLineEndingsAndWhiteSpace(String input) {
473-
return input
474-
.replace("\n", " ")
475-
.replace("\r", " ")
476-
.replaceAll("\\s+", " ")
477-
.replaceAll("\"\\s>", "\">")
478-
.replaceAll("\"\\s/>", "\"/>")
479-
.replaceAll("\\s+<", "<");
480-
481-
}
482-
483481
private Encounter extractEncounter(Bundle bundle) {
484482
return (Encounter) bundle.getEntry().stream()
485483
.map(Bundle.BundleEntryComponent::getResource)

0 commit comments

Comments
 (0)