Fix: [AEA-0000] - removes hardcoded text value (#220)

## Summary

**Remove items from this list if they are not relevant. Remove this line
once this has been done**

- Routine Change
- ❗ Breaking Change
- 🤖 Operational or Infrastructure Change
- ✨ New Feature
- ⚠️ Potential issues that might be caused by this change

### Details

Add any summary information of what is in the change. **Remove this line
if you have nothing to add.**

## Pull Request Naming

Pull requests should be named using the following format:

```text
Tag: [AEA-NNNN] - Short description
```

Tag can be one of:

- `Fix` - for a bug fix. (Patch release)
- `Update` - either for a backwards-compatible enhancement or for a rule
change that adds reported problems. (Patch release)
- `New` - implemented a new feature. (Minor release)
- `Breaking` - for a backwards-incompatible enhancement or feature.
(Major release)
- `Docs` - changes to documentation only. (Patch release)
- `Build` - changes to build process only. (No release)
- `Upgrade` - for a dependency upgrade. (Patch release)
- `Chore` - for refactoring, adding tests, etc. (anything that isn't
user-facing). (Patch release)

If the current release is x.y.z then
- a patch release increases z by 1
- a minor release increases y by 1
- a major release increases x by 1

Correct tagging is necessary for our automated versioning and release
process.

The description of your pull request will be used as the commit message
for the merge, and also be included in the changelog. Please ensure that
your title is sufficiently descriptive.

### Rerunning Checks

If you need to rename your pull request, you can restart the checks by
either:

- Closing and reopening the pull request
- pushing an empty commit 
  ```bash
  git commit --allow-empty -m 'trigger build'
  git push
  ```
- Amend your last commit and force push to the branch
  ```bash
  git commit --amend --no-edit
  git push --force
  ```

Rerunning the checks from within the pull request will not use the
updated title.

Author: bencegadanyi1-nhs

packages/cdk/resources/BedrockPromptResources.ts

@@ -14,6 +14,8 @@ export interface BedrockPromptResourcesProps {
 export class BedrockPromptResources extends Construct {
   public readonly queryReformulationPrompt: Prompt
   public readonly ragResponsePrompt: Prompt
+  public readonly ragModelId: string
+  public readonly queryReformulationModelId: string
 
   constructor(scope: Construct, id: string, props: BedrockPromptResourcesProps) {
     super(scope, id)
@@ -56,6 +58,10 @@ export class BedrockPromptResources extends Construct {
       variants: [ragResponsePromptVariant]
     })
 
+    // expose model IDs for use in Lambda environment variables
+    this.ragModelId = novaProModel.modelId
+    this.queryReformulationModelId = novaLiteModel.modelId
+
     this.queryReformulationPrompt = queryReformulationPrompt
     this.ragResponsePrompt = ragPrompt
   }

packages/cdk/resources/Functions.ts

@@ -5,10 +5,6 @@ import {StringParameter} from "aws-cdk-lib/aws-ssm"
 import {Secret} from "aws-cdk-lib/aws-secretsmanager"
 import {TableV2} from "aws-cdk-lib/aws-dynamodb"
 
-// Claude model for RAG responses
-const RAG_MODEL_ID = "anthropic.claude-3-sonnet-20240229-v1:0"
-// Claude model for query reformulation
-const QUERY_REFORMULATION_MODEL_ID = "anthropic.claude-3-haiku-20240307-v1:0"
 const BEDROCK_KB_DATA_SOURCE = "eps-assist-kb-ds"
 const LAMBDA_MEMORY_SIZE = "265"
 
@@ -38,6 +34,8 @@ export interface FunctionsProps {
   readonly ragResponsePromptVersion: string
   readonly isPullRequest: boolean
   readonly mainSlackBotLambdaExecutionRoleArn : string
+  readonly ragModelId: string
+  readonly queryReformulationModelId: string
 }
 
 export class Functions extends Construct {
@@ -58,8 +56,8 @@ export class Functions extends Construct {
       additionalPolicies: [props.slackBotManagedPolicy],
       dependencyLocation: ".dependencies/slackBotFunction",
       environmentVariables: {
-        "RAG_MODEL_ID": RAG_MODEL_ID,
-        "QUERY_REFORMULATION_MODEL_ID": QUERY_REFORMULATION_MODEL_ID,
+        "RAG_MODEL_ID": props.ragModelId,
+        "QUERY_REFORMULATION_MODEL_ID": props.queryReformulationModelId,
         "KNOWLEDGEBASE_ID": props.knowledgeBaseId,
         "BEDROCK_KB_DATA_SOURCE": BEDROCK_KB_DATA_SOURCE,
         "LAMBDA_MEMORY_SIZE": LAMBDA_MEMORY_SIZE,

packages/cdk/resources/RuntimePolicies.ts

@@ -1,11 +1,6 @@
 import {Construct} from "constructs"
 import {PolicyStatement, ManagedPolicy} from "aws-cdk-lib/aws-iam"
 
-// Claude model for RAG responses
-const RAG_MODEL_ID = "anthropic.claude-3-sonnet-20240229-v1:0"
-// Claude model for query reformulation
-const QUERY_REFORMULATION_MODEL_ID = "anthropic.claude-3-haiku-20240307-v1:0"
-
 export interface RuntimePoliciesProps {
   readonly region: string
   readonly account: string
@@ -17,6 +12,8 @@ export interface RuntimePoliciesProps {
   readonly guardrailArn: string
   readonly dataSourceArn: string
   readonly promptName: string
+  readonly ragModelId: string
+  readonly queryReformulationModelId: string
 }
 
 export class RuntimePolicies extends Construct {
@@ -30,8 +27,8 @@ export class RuntimePolicies extends Construct {
     const slackBotPolicy = new PolicyStatement({
       actions: ["bedrock:InvokeModel"],
       resources: [
-        `arn:aws:bedrock:${props.region}::foundation-model/${RAG_MODEL_ID}`,
-        `arn:aws:bedrock:${props.region}::foundation-model/${QUERY_REFORMULATION_MODEL_ID}`
+        `arn:aws:bedrock:${props.region}::foundation-model/${props.ragModelId}`,
+        `arn:aws:bedrock:${props.region}::foundation-model/${props.queryReformulationModelId}`
       ]
     })
 

packages/cdk/stacks/EpsAssistMeStack.ts

@@ -129,7 +129,9 @@ export class EpsAssistMeStack extends Stack {
       knowledgeBaseArn: vectorKB.knowledgeBase.attrKnowledgeBaseArn,
       guardrailArn: vectorKB.guardrail.guardrailArn,
       dataSourceArn: vectorKB.dataSourceArn,
-      promptName: bedrockPromptResources.queryReformulationPrompt.promptName
+      promptName: bedrockPromptResources.queryReformulationPrompt.promptName,
+      ragModelId: bedrockPromptResources.ragModelId,
+      queryReformulationModelId: bedrockPromptResources.queryReformulationModelId
     })
 
     // Create Functions construct with actual values from VectorKB
@@ -157,6 +159,8 @@ export class EpsAssistMeStack extends Stack {
       ragResponsePromptName: bedrockPromptResources.ragResponsePrompt.promptName,
       reformulationPromptVersion: bedrockPromptResources.queryReformulationPrompt.promptVersion,
       ragResponsePromptVersion: bedrockPromptResources.ragResponsePrompt.promptVersion,
+      ragModelId: bedrockPromptResources.ragModelId,
+      queryReformulationModelId: bedrockPromptResources.queryReformulationModelId,
       isPullRequest: isPullRequest,
       mainSlackBotLambdaExecutionRoleArn: mainSlackBotLambdaExecutionRoleArn
     })

packages/slackBotFunction/app/services/query_reformulator.py

@@ -13,10 +13,10 @@
 
 def reformulate_query(user_query: str) -> str:
     """
-    Reformulate user query using Claude Haiku for better RAG retrieval.
+    Reformulate user query using Amazon Nova Lite for better RAG retrieval.
 
     Loads prompt template from Bedrock Prompt Management, formats it with the user's
-    query, and uses Claude to generate a reformulated version optimized for vector search.
+    query, and uses Nova Lite to generate a reformulated version optimized for vector search.
     """
     try:
         client: BedrockRuntimeClient = boto3.client("bedrock-runtime", region_name=os.environ["AWS_REGION"])