Feat/dtoss 10668 amend postgresql flexible terraform module to parameterise prevent destroy lifecycle (#221)

* Ensure admins are destroyed before databases

* Increase the timeouts of the database deletes

Author: mrlockstar

infrastructure/modules/postgresql-flexible/database.tf

@@ -9,4 +9,14 @@ resource "azurerm_postgresql_flexible_server_database" "postgresql_flexible_db"
   lifecycle {
     prevent_destroy = false
   }
+
+  timeouts {
+    delete = "60m"
+  }
+
+  # Ensure admins are destroyed before databases
+  depends_on = [
+    azurerm_postgresql_flexible_server_active_directory_administrator.postgresql_admin,
+    azurerm_postgresql_flexible_server_active_directory_administrator.admin_identity
+  ]
 }

infrastructure/modules/postgresql-flexible/main.tf

@@ -69,6 +69,10 @@ resource "azurerm_postgresql_flexible_server_active_directory_administrator" "po
   object_id           = var.postgresql_admin_object_id
   principal_name      = var.postgresql_admin_principal_name
   principal_type      = var.postgresql_admin_principal_type
+
+  timeouts {
+    delete = "60m"
+  }
 }
 
 resource "azurerm_postgresql_flexible_server_active_directory_administrator" "admin_identity" {
@@ -83,6 +87,10 @@ resource "azurerm_postgresql_flexible_server_active_directory_administrator" "ad
   principal_name      = each.value.principal_name
   object_id           = each.value.object_id
   principal_type      = "ServicePrincipal"
+
+  timeouts {
+    delete = "60m"
+  }
 }
 
 # Create the server configurations