fix: fixing unit tests

Author: SamRobinson75684

application/CohortManager/src/Functions/CohortDistributionServices/TransformDataService/TransformDataLookupFacade.cs

@@ -68,13 +68,14 @@ public bool ValidateOutcode(string postcode)
             ?? throw new TransformationException("Postcode format invalid");
 
         // we can bypass checking the database if it's a dummy postcode
-        if (!parsedOutCode.isDummyPostCode)
+        if (parsedOutCode.isDummyPostCode)
         {
-            var result = _outcodeClient.GetSingle(parsedOutCode.outcode).Result;
-            return result != null;
+            return true;
         }
 
-        return true;
+        var result = _outcodeClient.GetSingle(parsedOutCode.outcode).Result;
+        return result != null;
+
     }
 
     /// <summary>

application/CohortManager/src/Functions/Shared/Common/ValidationHelper.cs

@@ -1,6 +1,7 @@
 namespace Common;
 
 using System.Globalization;
+using System.Linq.Expressions;
 using System.Text.RegularExpressions;
 using Hl7.Fhir.Validation;
 using Model;
@@ -111,20 +112,26 @@ public static bool ValidatePostcode(string postcode)
     /// </remarks>
     public static (string? outcode, bool isDummyPostCode) ParseOutcode(string postcode)
     {
-        bool isDummyPostCode = false;
         string pattern = @"^([A-Za-z][A-Za-z]?[0-9][A-Za-z0-9]?) ?[0-9][A-Za-z]{2}$";
-        string dummyOutCodePattern = @"(([A-Za-z][A-Za-z]?[0-9][A-Za-z0-9]?) ?[0-9][A-Za-z]{2}|[A-Z]{8})$";
+        string specialDummyOutCode = "ZZZSECUR";
 
         Match match = Regex.Match(postcode, pattern, RegexOptions.IgnoreCase, TimeSpan.FromSeconds(2));
-        Match matchDummyOutcode = Regex.Match(postcode, dummyOutCodePattern, RegexOptions.IgnoreCase, TimeSpan.FromSeconds(2));
-        if (!match.Success && !matchDummyOutcode.Success)
+
+        if (postcode == specialDummyOutCode)
+        {
+            return (postcode, true);
+        }
+
+        if (!match.Success)
         {
-            return (null, isDummyPostCode);
+            return (null, false);
         }
 
+
+
         string outcode = match.Groups[1].Value;
 
-        return (outcode, matchDummyOutcode.Success);
+        return (outcode, false);
     }
 
     private static bool ParseInt32(char value, out int integerValue)

tests/UnitTests/TransformDataServiceTests/TransformDataServiceTests/TransformDataLookupFacadeTests.cs

@@ -95,6 +95,23 @@ public void ValidateOutcode_OutcodeNotFound_ReturnFalse()
         Assert.IsFalse(result);
     }
 
+    [TestMethod]
+    public void ValidateOutcode_OutCodeIsSpecial_ReturnTrue()
+    {
+        // Arrange
+        _outcodeClientMock
+            .Setup(x => x.GetSingle(It.IsAny<string>()))
+            .ReturnsAsync((BsSelectOutCode)null);
+
+        string postcode = "ZZZSECUR";
+
+        // Act
+        bool result = _sut.ValidateOutcode(postcode);
+
+        // Assert
+        Assert.IsTrue(result);
+    }
+
     [TestMethod]
     [DataRow("")]
     [DataRow("ABC123")]