Hotfix 3.1 (#550)

Remove specified opening times bug

Author: JackPlowman

application/service_sync/changes_to_dos.py

@@ -98,23 +98,20 @@ def check_for_specified_opening_times_changes(self) -> bool:
                 "Removing Specified opening times that occur in the past",
                 extra={"all_nhs": nhs_spec_open_dates, "future_nhs": future_nhs_spec_open_dates},
             )
-        equal_specified_opening_times = SpecifiedOpeningTime.equal_lists(
-            dos_spec_open_dates, future_nhs_spec_open_dates
-        )
-        if not equal_specified_opening_times or len(nhs_spec_open_dates) != len(future_nhs_spec_open_dates):
+        if SpecifiedOpeningTime.equal_lists(dos_spec_open_dates, future_nhs_spec_open_dates):
             logger.info(
-                "Specified opening times not equal",
+                "Specified opening times are equal, so no change",
                 extra={"dos": dos_spec_open_dates, "nhs": future_nhs_spec_open_dates},
             )
-            self.current_specified_opening_times = dos_spec_open_dates
-            self.new_specified_opening_times = future_nhs_spec_open_dates
-            return True
+            return False
         else:
             logger.info(
-                "Specified opening times are equal, so no change",
+                "Specified opening times not equal",
                 extra={"dos": dos_spec_open_dates, "nhs": future_nhs_spec_open_dates},
             )
-            return False
+            self.current_specified_opening_times = dos_spec_open_dates
+            self.new_specified_opening_times = future_nhs_spec_open_dates
+            return True
 
     def check_for_address_and_postcode_for_changes(self) -> Tuple[bool, bool, Optional[DoSLocation]]:
         """Check if address and postcode have changed between dos_service and nhs_entity,