DI-449 Update and add Github Pull Request Checklists (#358)

* Add basic template to be used when action runs

* Update task and test PR templates

* Simplify Workflow to use single file

* Experiment with environment variables

* Add test branches to regex

* Reword template files

Co-authored-by: Jack Plowman <jack.plowman1@nhs.net>

Author: 2 people

.github/pull_request_template.md …-templates/task_pull_request_template.md.github/pull_request_template.md renamed to .github/pull-request-templates/task_pull_request_template.md .github/pull_request_template.md renamed to .github/pull-request-templates/task_pull_request_template.md

@@ -1,46 +1,32 @@
-## Link to JIRA Ticket
+# Task Branch Pull Request
 
--
+**<https://nhsd-jira.digital.nhs.uk/browse/{{ .BRANCH_NUMBER }}>**
 
-## Description
+## Description of Changes
 
 Please include a summary of the change
 
-### Noteworthy Changes
-
-- These are changes the reviewer should look out for
-
 ## Type of change
 
 Delete not appropriate
 
 - Bug fix (non-breaking change which fixes an issue)
 - New feature (non-breaking change which adds functionality)
 - Breaking change (fix or feature that would cause existing functionality to not work as expected)
-- This change requires a documentation update
-
-## Testing
+- Refactoring (non-breaking change which improves the structure of the code)
 
-Please tick the testing that has been completed
-
-- [ ] Unit tests
-- [ ] Integration tests
-
-## Developer Checklist
+## Development Checklist
 
 - [ ] I have performed a self-review of my own code
 - [ ] I have run the [code formatting checks](../README.md#code-quality)
 - [ ] I have run the [code quality checks](../README.md#code-quality)
 - [ ] New code meets [standards](https://nhsd-confluence.digital.nhs.uk/display/DI/DI+Ways+of+Working) agreed by the team
-- [ ] Unit test code coverage is at or above 80%
-- [ ] New and existing unit tests pass locally with my changes
 - [ ] Tests have added that prove my fix is effective or that my feature works (Integration tests)
-- [ ] I have made corresponding changes to the documentation
 - [ ] I have updated Dependabot to include my changes (if applicable)
 
 ## Code Reviewer Checklist
 
-- [ ] I have run the unit tests and they run correctly
 - [ ] I can confirm the changes have been tested or approved by a tester
-- [ ] I can confirm no remaining infrastructure is left over from this branch
 - [ ] I have checked any ignore commands for code linting tools and I agree that the code is safe
+
+**Note: Please don't approve your own pull requests if avoidable.**

.github/pull-request-templates/test_pull_request_template.md

@@ -0,0 +1,24 @@
+# Test Branch Pull Request
+
+## What branch do these tests check?
+
+-
+
+## Description of changes/tests
+
+Why do these tests need to exist?/When should the test be run?
+
+## Development Checklist
+
+- [ ] The tests are tagged correctly
+- [ ] The tests will be run in the development pipeline
+- [ ] The tests are stable and pass
+- [ ] I have used reusable functions and classes where possible
+
+## Code Reviewer Checklist
+
+- [ ] I am confident the tests are stable and have passed
+- [ ] I am confident the tests will be run in the development pipeline
+- [ ] I believe the tests developed in a way which makes them reusable and maintainable
+
+**Note: Please don't approve your own pull requests if avoidable.**

.github/workflows/create-pull-request.yml

@@ -0,0 +1,33 @@
+name: "Create Pull Requests"
+on:
+  push:
+    branches:
+    - "task/*"
+    - "test/*"
+
+jobs:
+  pull-request:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Get branch number
+        run: echo "BRANCH_NUMBER=$(echo ${{ github.ref_name }} | grep -Eo '[A-Za-z]{2,5}-[0-9]{1,5}')" >> $GITHUB_ENV
+      - name: Get branch designator
+        run: echo "BRANCH_DESIGNATOR=$(echo ${{ github.ref_name }} | sed 's|/.*||')" >> $GITHUB_ENV
+      - name: Render Pull Request template
+        id: template
+        uses: chuhlomin/render-template@v1.4
+        with:
+          template: .github/pull-request-templates/${{ env.BRANCH_DESIGNATOR }}_pull_request_template.md
+          vars: |
+            BRANCH_NUMBER: ${{ env.BRANCH_NUMBER }}
+            BRANCH_DESIGNATOR: ${{ env.BRANCH_DESIGNATOR }}
+      - name: Create Pull Request
+        uses: repo-sync/pull-request@v2
+        with:
+          destination_branch: "develop"
+          pr_title: "${{ github.ref_name }} into develop"
+          pr_body: ${{ steps.template.outputs.result }}
+          pr_draft: true
+          github_token: ${{ secrets.GITHUB_TOKEN }}