[GPCAPIM-395]: Clean up logging and improve session handling in APIM stubs

Author: DWolfsNHS

gateway-api/src/gateway_api/apim_app_auth/apim.py

@@ -23,17 +23,10 @@
 def _make_session_post(
     session: requests.Session, endpoint: str, data: dict[str, str]
 ) -> requests.Response:
-    print("DaveW: in _make_session_post STUB_APIM_APP_AUTH", STUB_APIM_APP_AUTH)
     if not STUB_APIM_APP_AUTH:
-        print("DaveW: in if ", session.post)
         return session.post(endpoint, data=data)
     else:
         stub = APIMAppAuthStub()
-        print("Dave W: in _make_session_post, stub:", stub.session_post)
-        print(
-            "Dave W: in _make_session_post, session_post:",
-            stub.session_post(session, endpoint, data),
-        )
         response = stub.session_post(session, endpoint, data)
         return response
 

gateway-api/stubs/stubs/apim_app_auth/stub.py

@@ -4,7 +4,6 @@
 The stub does **not** implement the full APIM APP Auth API surface.
 """
 
-import logging
 from typing import Any
 
 from requests import Response, Session
@@ -60,8 +59,6 @@ def session_post(
         data: str | dict[str, str],  # noqa: ARG002 - required to match subclass signature
         **kwargs: Any,  # noqa: ARG002 - required to match subclass signature
     ) -> Response:
-        logger = logging.getLogger(__name__)
-        logger.info("DaveW in stub session_post data: %s", data)
         if session is None:
             raise ValueError("Session must be provided for APIMAppAuthStub")