From d7d59cbd0a17030164e409efe294d84ca9f39a32 Mon Sep 17 00:00:00 2001 From: Ryan May <112563297+ryma2fhir@users.noreply.github.com> Date: Tue, 21 May 2024 13:34:22 +0100 Subject: [PATCH 1/3] Update common.js.ts --- src/common.js.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/common.js.ts b/src/common.js.ts index e310563..9aaf57e 100644 --- a/src/common.js.ts +++ b/src/common.js.ts @@ -264,6 +264,8 @@ function raiseWarning(issue: OperationOutcomeIssue, failOnWarning:boolean): bool } // THESE WARNINGS SHOULD ALWAYS BE SILENTLY IGNORED + // Issue with GitHub validator requiring code to be in CodeSystem asset when there is none. No issues with the validator itself. The ValueSet in question is https://terminology.hl7.org/5.5.0/CodeSystem-v3-hgvs.html + if (issue.diganostics.includes('http://varnomen.hgvs.org') return false //if (issue.diagnostics.includes('Code system https://dmd.nhs.uk/ could not be resolved.')) return false // Issue with hapi giving incorrect error when one code is from the valueset, but another is not. See https://github.com/hapifhir/hapi-fhir/issues/4152 if (issue.diagnostics.includes('Inappropriate CodeSystem URL') && issue.diagnostics.includes('for ValueSet: http://hl7.org/fhir/ValueSet/all-languages')) { From 38f6bf036eef61f913ef946aa285ed49a55579f7 Mon Sep 17 00:00:00 2001 From: Ryan May <112563297+ryma2fhir@users.noreply.github.com> Date: Tue, 21 May 2024 13:36:59 +0100 Subject: [PATCH 2/3] Update common.js.ts --- src/common.js.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common.js.ts b/src/common.js.ts index 9aaf57e..a9392c5 100644 --- a/src/common.js.ts +++ b/src/common.js.ts @@ -265,7 +265,7 @@ function raiseWarning(issue: OperationOutcomeIssue, failOnWarning:boolean): bool // THESE WARNINGS SHOULD ALWAYS BE SILENTLY IGNORED // Issue with GitHub validator requiring code to be in CodeSystem asset when there is none. No issues with the validator itself. The ValueSet in question is https://terminology.hl7.org/5.5.0/CodeSystem-v3-hgvs.html - if (issue.diganostics.includes('http://varnomen.hgvs.org') return false + if (issue.diganostics.includes('http://varnomen.hgvs.org')) return false //if (issue.diagnostics.includes('Code system https://dmd.nhs.uk/ could not be resolved.')) return false // Issue with hapi giving incorrect error when one code is from the valueset, but another is not. See https://github.com/hapifhir/hapi-fhir/issues/4152 if (issue.diagnostics.includes('Inappropriate CodeSystem URL') && issue.diagnostics.includes('for ValueSet: http://hl7.org/fhir/ValueSet/all-languages')) { From db804c9e32bb6ffe773183f1032691e974c2cb02 Mon Sep 17 00:00:00 2001 From: Ryan May <112563297+ryma2fhir@users.noreply.github.com> Date: Tue, 21 May 2024 14:32:07 +0100 Subject: [PATCH 3/3] fix spelling mistake --- src/common.js.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common.js.ts b/src/common.js.ts index a9392c5..d0d0c10 100644 --- a/src/common.js.ts +++ b/src/common.js.ts @@ -265,7 +265,7 @@ function raiseWarning(issue: OperationOutcomeIssue, failOnWarning:boolean): bool // THESE WARNINGS SHOULD ALWAYS BE SILENTLY IGNORED // Issue with GitHub validator requiring code to be in CodeSystem asset when there is none. No issues with the validator itself. The ValueSet in question is https://terminology.hl7.org/5.5.0/CodeSystem-v3-hgvs.html - if (issue.diganostics.includes('http://varnomen.hgvs.org')) return false + if (issue.diagnostics.includes('http://varnomen.hgvs.org')) return false //if (issue.diagnostics.includes('Code system https://dmd.nhs.uk/ could not be resolved.')) return false // Issue with hapi giving incorrect error when one code is from the valueset, but another is not. See https://github.com/hapifhir/hapi-fhir/issues/4152 if (issue.diagnostics.includes('Inappropriate CodeSystem URL') && issue.diagnostics.includes('for ValueSet: http://hl7.org/fhir/ValueSet/all-languages')) {