Skip to content

Commit 81c185f

Browse files
authored
Merge pull request #95 from NHSDigital/ryma2fhir-patch-1
Update QualityControlChecker.py to allow for programmes email addresses
2 parents bd7b13a + 7c87891 commit 81c185f

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

QualityControlChecker/QualityControlChecker.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,11 @@ def checkContactDetailsXML(root,path,warnings):
144144
warnings.append("\t\tcontact.name - This SHALL be '"+mainVar['org']+"'")
145145
except:
146146
print("\t\tcontact.name - This element is missing")
147-
148-
contact = {'system':'email','value':mainVar['email'],'use':'work','rank':'1'}
147+
if 'value' in mainVar:
148+
contact = {'system':'email','value':mainVar['email'],'use':'work','rank':'1'}
149+
else:
150+
contact = {'system':'email','use':'work','rank':'1'}
151+
149152
for key,value in contact.items():
150153
try:
151154
if not root.findall('.//{*}'+str(key))[0].get('value') == value:
@@ -166,7 +169,11 @@ def checkContactDetailsJSON(jsonFile,warnings):
166169
except:
167170
warnings.append("\t\tcontact.name - This SHALL be '"+mainVar['org']+"'")
168171

169-
contact = {'system':'email','value':mainVar['email'],'use':'work','rank':1}
172+
if 'value' in mainVar:
173+
contact = {'system':'email','value':mainVar['email'],'use':'work','rank':'1'}
174+
else:
175+
contact = {'system':'email','use':'work','rank':'1'}
176+
170177
for key,value in contact.items():
171178
try:
172179
if not jsonFile['contact'][0]['telecom'][0][key] == value:

0 commit comments

Comments
 (0)