Skip to content

Commit bebee38

Browse files
authored
Fix ci failure (kptdev#4435)
CI failure due to renderstatus merge fixed. Env variable to use nodejs as wasm env moved to Makefile from Github workflow Signed-off-by: aravind.est <aravindhan.a@est.tech>
1 parent 1dc583f commit bebee38

3 files changed

Lines changed: 5 additions & 13 deletions

File tree

.github/workflows/go.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ jobs:
6767
make test-docker
6868
env:
6969
KRM_FN_RUNTIME: ${{ matrix.runtime }}
70-
KPT_FN_WASM_RUNTIME: nodejs
7170

7271
build-macos:
7372
runs-on: macos-latest

Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ YEAR_GEN := $(shell date '+%Y')
2222
GOBIN := $(shell go env GOPATH)/bin
2323
GIT_COMMIT := $(shell git rev-parse --short HEAD)
2424

25+
export KPT_FN_WASM_RUNTIME ?= nodejs
26+
2527
LDFLAGS := -ldflags "-X github.com/kptdev/kpt/run.version=${GIT_COMMIT}
2628
ifeq ($(OS),Windows_NT)
2729
# Do nothing

e2e/testdata/fn-render/basicpipeline-wasm/.expected/diff.patch

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,9 @@
11
diff --git a/Kptfile b/Kptfile
2-
index ffcf186..9c131fb 100644
2+
index 17a7822..94b6f80 100644
33
--- a/Kptfile
44
+++ b/Kptfile
5-
@@ -6,12 +6,14 @@ metadata:
6-
tier: backend
7-
pipeline:
8-
mutators:
9-
- # The following 2 images are built from https://github.com/kptdev/krm-functions-catalog/pull/898.
10-
- image: gcr.io/kpt-fn-demo/set-namespace:v0.5.0
11-
- # ghcr.io/kptdev/krm-functions-catalog/wasm/set-namespace:v0.5.0
12-
configMap:
13-
namespace: staging
14-
- image: gcr.io/kpt-fn-demo/set-labels:v0.2.0
15-
- # ghcr.io/kptdev/krm-functions-catalog/wasm/set-labels:v0.2.0
5+
@@ -12,3 +12,8 @@ pipeline:
6+
- image: ghcr.io/kptdev/krm-functions-catalog/wasm/set-labels:v0.2.4
167
configMap:
178
tier: backend
189
+status:

0 commit comments

Comments
 (0)