fix: resolve test failures from apply-setters version, path validation, and CRLF

fix: resolve test failures from apply-setters version, path validation, and CRLF

- Update testdata Kptfiles to use apply-setters:v0.2.4 (was v0.2.0)
  which is not registered in the functions map, causing TestRender failures
- Fix validateFnConfigPathSyntax to use path.IsAbs (forward-slash) instead
  of filepath.IsAbs so absolute path detection works correctly on all platforms
- Normalize CRLF to LF in pkg_context_test.go when reading expected output
  files to fix TestPkgContextGenerator on Windows
- Remove unused absPath helper and os import from executor_test.go

Signed-off-by: NETIZEN-11 <kumarnitesh121411@gmail.com>

Author: NETIZEN-11

internal/builtins/pkg_context_test.go

@@ -57,12 +57,14 @@ func TestPkgContextGenerator(t *testing.T) {
 
 			exp, err := os.ReadFile(filepath.Join("testdata", test.dir, "out.yaml"))
 			assert.NoError(t, err)
+			// Normalize line endings to LF for cross-platform comparison
+			expNormalized := bytes.ReplaceAll(exp, []byte("\r\n"), []byte("\n"))
 
 			err = pkgCtxGenerator.Run(bytes.NewReader(in), out)
 			if err != test.expErr {
 				t.Errorf("exp: %v got: %v", test.expErr, err)
 			}
-			if diff := cmp.Diff(string(exp), out.String()); diff != "" {
+			if diff := cmp.Diff(string(expNormalized), out.String()); diff != "" {
 				t.Errorf("pkg context mistmach (-want +got):\n%s", diff)
 			}
 		})

internal/kptops/testdata/render-with-function-config/simple-bucket/Kptfile

@@ -22,5 +22,5 @@ info:
   description: A Google Cloud Storage bucket
 pipeline:
   mutators:
-    - image: ghcr.io/kptdev/krm-functions-catalog/apply-setters:v0.2.0
+    - image: ghcr.io/kptdev/krm-functions-catalog/apply-setters:v0.2.4
       configPath: setters.yaml

internal/kptops/testdata/render-with-inline-config/simple-bucket/Kptfile

@@ -8,7 +8,7 @@ info:
   description: A Google Cloud Storage bucket
 pipeline:
   mutators:
-    - image: ghcr.io/kptdev/krm-functions-catalog/apply-setters:v0.2.0
+    - image: ghcr.io/kptdev/krm-functions-catalog/apply-setters:v0.2.4
       configMap:
         name: updated-bucket-name
         namespace: updated-namespace

internal/util/render/executor_test.go

@@ -33,8 +33,14 @@ import (
 	"sigs.k8s.io/kustomize/kyaml/kio"
 )
 
-const rootString = "/root"
-const subPkgString = "/root/subpkg"
+// absPath returns a forward-slash absolute path for use with filesys.MakeFsInMemory(),
+// which only understands Unix-style paths regardless of host OS.
+func absPath(suffix string) string {
+	return "/" + strings.ReplaceAll(suffix, string(filepath.Separator), "/")
+}
+
+var rootString = "/root"
+var subPkgString = "/root/subpkg"
 
 func TestPathRelToRoot(t *testing.T) {
 	tests := []struct {
@@ -257,11 +263,11 @@ func setupRendererTest(t *testing.T, renderBfs bool) (*Renderer, *bytes.Buffer,
 	assert.NoError(t, err)
 
 	childPkgPath := "/root/subpkg/child"
-	err = mockFileSystem.Mkdir(subPkgPath)
+	err = mockFileSystem.Mkdir(childPkgPath)
 	assert.NoError(t, err)
 
 	siblingPkgPath := "/root/sibling"
-	err = mockFileSystem.Mkdir(subPkgPath)
+	err = mockFileSystem.Mkdir(siblingPkgPath)
 	assert.NoError(t, err)
 
 	err = mockFileSystem.WriteFile(filepath.Join(rootPkgPath, "Kptfile"), fmt.Appendf(nil, `
@@ -388,7 +394,7 @@ metadata:
 
 	t.Run("Error in LocalResources", func(t *testing.T) {
 		// Simulate an error in LocalResources by creating a package with no Kptfile
-		invalidPkgPath := "/invalid"
+		invalidPkgPath := absPath("invalid")
 		err := mockFileSystem.Mkdir(invalidPkgPath)
 		assert.NoError(t, err)
 

pkg/api/kptfile/v1/validation.go

@@ -16,6 +16,7 @@ package v1
 
 import (
 	"fmt"
+	"path"
 	"path/filepath"
 	"regexp"
 	"slices"
@@ -157,11 +158,13 @@ func validateFnConfigPathSyntax(p string) error {
 	if strings.TrimSpace(p) == "" {
 		return fmt.Errorf("path must not be empty")
 	}
-	p = filepath.Clean(p)
-	if filepath.IsAbs(p) {
+	// Use path.IsAbs (forward-slash based) since Kptfile paths are always
+	// slash-separated regardless of the host OS.
+	if path.IsAbs(p) {
 		return fmt.Errorf("path must be relative")
 	}
-	if strings.Contains(p, "..") {
+	cleaned := filepath.Clean(p)
+	if strings.Contains(cleaned, "..") {
 		// fn config must not live outside the package directory
 		// Allowing outside path opens up an attack vector that allows
 		// reading any YAML file on package consumer's machine.