Skip to content

Commit 367947b

Browse files
danbevMayaLekova
authored andcommitted
src: use smart pointer in AsyncWrap::WeakCallback
PR-URL: nodejs#19168 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent a07154f commit 367947b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/async_wrap.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -415,14 +415,14 @@ void AsyncWrap::WeakCallback(const v8::WeakCallbackInfo<DestroyParam>& info) {
415415
HandleScope scope(info.GetIsolate());
416416

417417
Environment* env = Environment::GetCurrent(info.GetIsolate());
418-
DestroyParam* p = info.GetParameter();
418+
std::unique_ptr<DestroyParam> p{info.GetParameter()};
419419
Local<Object> prop_bag = PersistentToLocal(info.GetIsolate(), p->propBag);
420420

421421
Local<Value> val = prop_bag->Get(env->destroyed_string());
422422
if (val->IsFalse()) {
423423
AsyncWrap::EmitDestroy(env, p->asyncId);
424424
}
425-
delete p;
425+
// unique_ptr goes out of scope here and pointer is deleted.
426426
}
427427

428428

0 commit comments

Comments
 (0)