refactor(main): simplify _updateDom with async/await (MagicMirrorOrg#4185)

`_updateDom` was wrapping its entire body in a `new Promise(resolve =>
{...})` constructor just to chain `getDom()` and
`updateDomWithContent()` together. Since `updateDomWithContent` was
already converted to async in MagicMirrorOrg#4182, we can now just `await` it directly
- the manual wrapper, the explicit `Promise.resolve()` normalization,
and the nested `.then().catch()` chain all become unnecessary, making
the control flow easier to follow.
Also added `.catch(Log.error)` at both call sites, since async functions
reject on error instead of swallowing it silently.

Author: KristjanESPERANTO

js/main.js

@@ -8,7 +8,7 @@ let modules = [];
 /**
  * Create dom objects for all modules that are configured for a specific position.
  */
-function createDomObjects () {
+async function createDomObjects () {
 	const domCreationPromises = [];
 
 	modules.forEach(function (module) {
@@ -58,19 +58,16 @@ function createDomObjects () {
 
 		domCreationPromises.push(domCreationPromise);
 		domCreationPromise
-			.then(function () {
-				_sendNotification("MODULE_DOM_CREATED", null, null, module);
-			})
+			.then(
+				() => _sendNotification("MODULE_DOM_CREATED", null, null, module)
+			)
 			.catch(Log.error);
 	});
 
 	updateWrapperStates();
 
-	Promise.all(domCreationPromises)
-		.then(function () {
-			_sendNotification("DOM_OBJECTS_CREATED");
-		})
-		.catch(Log.error);
+	await Promise.all(domCreationPromises);
+	_sendNotification("DOM_OBJECTS_CREATED");
 }
 
 /**
@@ -166,20 +163,11 @@ async function updateDomWithContent (module, speed, newHeader, newContent, anima
 		return;
 	}
 
-	await new Promise((resolve) => {
-		_hideModule(
-			module,
-			speed / 2,
-			function () {
-				updateModuleContent(module, newHeader, newContent);
-				if (!module.hidden) {
-					_showModule(module, speed / 2, null, { animate: animateIn });
-				}
-				resolve();
-			},
-			{ animate: animateOut }
-		);
-	});
+	await new Promise((resolve) => _hideModule(module, speed / 2, resolve, { animate: animateOut }));
+	updateModuleContent(module, newHeader, newContent);
+	if (!module.hidden) {
+		await new Promise((resolve) => _showModule(module, speed / 2, resolve, { animate: animateIn }));
+	}
 }
 
 /**
@@ -241,7 +229,7 @@ function updateModuleContent (module, newHeader, newContent) {
  * Hide the module.
  * @param {Module} module The module to hide.
  * @param {number} speed The speed of the hide animation.
- * @param {Promise} callback Called when the animation is done.
+ * @param {() => void} callback Called when the animation is done.
  * @param {object} [options] Optional settings for the hide method.
  */
 function _hideModule (module, speed, callback, options = {}) {
@@ -325,7 +313,7 @@ function _hideModule (module, speed, callback, options = {}) {
  * Show the module.
  * @param {Module} module The module to show.
  * @param {number} speed The speed of the show animation.
- * @param {Promise} callback Called when the animation is done.
+ * @param {() => void} callback Called when the animation is done.
  * @param {object} [options] Optional settings for the show method.
  */
 function _showModule (module, speed, callback, options = {}) {
@@ -657,7 +645,7 @@ export const MM = {
 	 * @param {Module} module The module that needs an update.
 	 * @param {object|number} [updateOptions] The (optional) number of microseconds for the animation or object with updateOptions (speed/animates)
 	 */
-	updateDom (module, updateOptions) {
+	async updateDom (module, updateOptions) {
 		if (!(module instanceof Module)) {
 			Log.error("updateDom: Sender should be a module.");
 			return;
@@ -669,12 +657,9 @@ export const MM = {
 		}
 
 		// Further implementation is done in the private method.
-		_updateDom(module, updateOptions)
-			.then(function () {
-				// Once the update is complete and rendered, send a notification to the module that the DOM has been updated
-				_sendNotification("MODULE_DOM_UPDATED", null, null, module);
-			})
-			.catch(Log.error);
+		await _updateDom(module, updateOptions);
+		// Once the update is complete and rendered, send a notification to the module that the DOM has been updated
+		_sendNotification("MODULE_DOM_UPDATED", null, null, module);
 	},
 
 	/**
@@ -690,7 +675,7 @@ export const MM = {
 	 * Hide the module.
 	 * @param {Module} module The module to hide.
 	 * @param {number} speed The speed of the hide animation.
-	 * @param {Promise} callback Called when the animation is done.
+	 * @param {() => void} callback Called when the animation is done.
 	 * @param {object} [options] Optional settings for the hide method.
 	 */
 	hideModule (module, speed, callback, options) {
@@ -702,7 +687,7 @@ export const MM = {
 	 * Show the module.
 	 * @param {Module} module The module to show.
 	 * @param {number} speed The speed of the show animation.
-	 * @param {Promise} callback Called when the animation is done.
+	 * @param {() => void} callback Called when the animation is done.
 	 * @param {object} [options] Optional settings for the show method.
 	 */
 	showModule (module, speed, callback, options) {