Commit 74671d0
feat(decisioning): re-export SignalsFeatures + ContentStandards capability sub-models
Closes the re-export gap flagged by the code-reviewer in adcontextprotocol#484
(post-merge polish issue adcontextprotocol#485 P1). Two capability sub-models were
reachable via Pydantic nested construction but not surfaced through
:mod:`adcp.decisioning.capabilities`, forcing adopters to dig into
``generated_poc`` for deep declarations.
* ``SignalsFeatures`` — codegen name ``Features2`` (numbered because
``Features`` already names the media_buy features block). Surfaced
under a stable adopter-facing name so ``Signals(features=...)``
declarations read cleanly.
* ``ContentStandards`` — type of ``MediaBuy.content_standards``.
Collides with ``adcp.types.ContentStandards`` (unrelated wire model
on the content-standards protocol), so disambiguated via
``CapabilitiesContentStandards`` in :mod:`adcp.types.capabilities`
and re-aliased back to the wire-spec name within
:mod:`adcp.decisioning.capabilities`. Same pattern as ``Account`` /
``MediaBuy`` / ``Creative``.
One new regression test guards both re-exports against future drift.
Refs adcontextprotocol#485
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent f5cd8cf commit 74671d0
3 files changed
Lines changed: 57 additions & 1 deletion
File tree
- src/adcp
- decisioning
- types
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| 80 | + | |
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
| |||
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
93 | 97 | | |
94 | 98 | | |
95 | 99 | | |
| |||
110 | 114 | | |
111 | 115 | | |
112 | 116 | | |
| 117 | + | |
113 | 118 | | |
114 | 119 | | |
115 | 120 | | |
| |||
134 | 139 | | |
135 | 140 | | |
136 | 141 | | |
| 142 | + | |
137 | 143 | | |
138 | 144 | | |
139 | 145 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
100 | 109 | | |
101 | 110 | | |
102 | 111 | | |
103 | 112 | | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
104 | 121 | | |
105 | 122 | | |
106 | 123 | | |
| |||
126 | 143 | | |
127 | 144 | | |
128 | 145 | | |
| 146 | + | |
129 | 147 | | |
130 | 148 | | |
131 | 149 | | |
| |||
152 | 170 | | |
153 | 171 | | |
154 | 172 | | |
155 | | - | |
156 | 173 | | |
| 174 | + | |
| 175 | + | |
157 | 176 | | |
158 | 177 | | |
159 | 178 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
137 | 168 | | |
138 | 169 | | |
139 | 170 | | |
| |||
0 commit comments