CI: nigtly fix

Author: dantti

.clang-tidy

@@ -0,0 +1,22 @@
+---
+Checks:          'clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,*,-google-*,-cppcoreguidelines-*,-readability-else-after-return,-readability-implicit-bool-cast,-llvm-include-order,-readability-named-parameter,-readabilty-namespace-comments,-llvm-namespace-comment,-clang-analyzer-alpha.core.CastToStruct,-modernize-use-override,-modernize-use-bool-literals,-clang-analyzer-cplusplus.NewDeleteLeaks,-clang-analyzer-alpha.deadcode.UnreachableCode,-modernize-use-default,-clang-analyzer-core.CallAndMessage,-modernize-pass-by-value,-clang-analyzer-core.NonNullParamChecker,-modernize-raw-string-literal,-modernize-use-using,-modernize-loop-convert,-modernize-use-emplace,-modernize-return-braced-init-list,-modernize-use-default-member-init,-modernize-use-equals-default,-fuchsia-*,-hicpp-*,-readability-implicit-bool-conversion,-llvm-*,-llvmlibc-*,-modernize-use-trailing-return-type,-readability-magic-numbers,-readability-qualified-auto,-clang-diagnostic-gnu-zero-variadic-macro-arguments,-android-*,-misc-no-recursion,-modernize-avoid-c-arrays,-misc-non-private-member-variables-in-classes,-readability-redundant-access-specifiers'
+WarningsAsErrors: ''
+HeaderFilterRegex: ''
+CheckOptions:
+  - key:             cert-oop11-cpp.UseCERTSemantics
+    value:           '1'
+  - key:             modernize-loop-convert.MaxCopySize
+    value:           '16'
+  - key:             modernize-loop-convert.MinConfidence
+    value:           reasonable
+  - key:             modernize-loop-convert.NamingStyle
+    value:           CamelCase
+  - key:             modernize-pass-by-value.IncludeStyle
+    value:           llvm
+  - key:             modernize-replace-auto-ptr.IncludeStyle
+    value:           llvm
+  - key:             modernize-use-nullptr.NullMacros
+    value:           'NULL'
+  - key:             readability-braces-around-statements.ShortStatementLines
+    value:           '3'
+...

.github/workflows/nightly.yml

@@ -25,13 +25,7 @@ jobs:
               - cppcheck
 
     steps:
-      - name: Install Qt ${{ matrix.config.qt_version }} with options and default aqtversion
-        uses: jurplel/install-qt-action@v4
-        with:
-          version: ${{ matrix.config.qt_version }}
-          cache: true
-
-      - name: Install ninja-build tool (must be after Qt due PATH changes)
+      - name: Install ninja-build tool
         uses: turtlesec-no/get-ninja@main
 
       - name: Install dependencies on Ubuntu (${{ join(matrix.config.apt_pgks, ' ') }})
@@ -41,12 +35,6 @@ jobs:
           echo ${{ join(matrix.config.apt_pgks, ' ') }} | xargs sudo apt install -y
 
       - uses: actions/checkout@v4
-        #with:
-          #ref: '2.0' # schedule.cron do not allow branch setting
-
-      - name: Make sure MSVC is found when Ninja generator is in use
-        if: ${{ runner.os == 'Windows' }}
-        uses: ilammy/msvc-dev-cmd@v1
 
       - name: Configure project
         run: cmake --preset=${{ matrix.config.preset }}
@@ -55,12 +43,6 @@ jobs:
         id: ctest
         run: cmake --build --preset=${{ matrix.config.preset }}
 
-      - name: Read tests log when it fails
-        uses: andstor/file-reader-action@v1
-        if: ${{ steps.ctest.conclusion == 'failure' }}
-        with:
-          path: "./build/Testing/Temporary/LastTest.log"
-
       - name: Run cppcheck
         if: ${{ matrix.config.preset == 'clang-tidy' }}
         run: cmake --build --preset=${{ matrix.config.preset }} --target cppcheck

CMakeLists.txt

@@ -67,5 +67,5 @@ add_custom_target(cppcheck
         --check-level=exhaustive
         --library=qt.cfg
         "-i${CMAKE_CURRENT_BINARY_DIR}/_deps/"
-        "--suppress=*:${CMAKE_CURRENT_BINARY_DIR}/_deps/*"
+        "--suppress=*:${CMAKE_CURRENT_BINARY_DIR}/_deps/"
 )

CMakePresets.json

@@ -110,15 +110,13 @@
             "name":"ci",
             "inherits":"ci-base"
         },
-        {
-            "name":"clazy",
-            "inherits":"ci-base"
-        },
         {
             "name":"clang-tidy",
             "inherits":"ci-base",
             "cacheVariables":{
-                "CMAKE_CXX_CLANG_TIDY":"clang-tidy"
+                "CMAKE_CXX_CLANG_TIDY":"clang-tidy;--config-file=${sourceDir}/.clang-tidy",
+                "CMAKE_COMPILE_WARNING_AS_ERROR":"OFF",
+                "KDSPDSETUP_BUILD_DOCS":"OFF"
             }
         }
     ],
@@ -127,14 +125,6 @@
             "name":"ci",
             "configurePreset":"ci"
         },
-        {
-            "name":"clazy",
-            "configurePreset":"clazy",
-            "environment":{
-                "CLAZY_CHECKS":"level2,no-qstring-allocations,no-fully-qualified-moc-types,no-copyable-polymorphic",
-                "CCACHE_DISABLE":"ON"
-            }
-        },
         {
             "name":"clang-tidy",
             "configurePreset":"clang-tidy"

cmake/dependencies/doctest.cmake

@@ -23,6 +23,8 @@ if(NOT TARGET doctest)
         doctest
         GIT_REPOSITORY https://github.com/doctest/doctest.git
         GIT_TAG master
+        EXCLUDE_FROM_ALL
+        SYSTEM
     )
     fetchcontent_makeavailable(doctest)
 

cmake/dependencies/doxygen.cmake

@@ -23,6 +23,8 @@ if(NOT DOXYGEN_FOUND)
         Doxygen
         GIT_REPOSITORY https://github.com/doxygen/doxygen.git
         GIT_TAG Release_1_9_5
+        EXCLUDE_FROM_ALL
+        SYSTEM
     )
     fetchcontent_makeavailable(Doxygen)
 

cmake/dependencies/spdlog.cmake

@@ -27,6 +27,7 @@ if(NOT TARGET spdlog::spdlog)
         GIT_REPOSITORY https://github.com/gabime/spdlog.git
         GIT_TAG v1.11.0
         EXCLUDE_FROM_ALL
+        SYSTEM
     )
     fetchcontent_makeavailable(spdlog)
 

cmake/dependencies/toml11.cmake

@@ -23,6 +23,8 @@ if(NOT TARGET toml11)
         toml11
         GIT_REPOSITORY https://github.com/ToruNiina/toml11.git
         GIT_TAG master
+        EXCLUDE_FROM_ALL
+        SYSTEM
     )
     fetchcontent_makeavailable(toml11)
 

src/KDSpdSetup/setup.cpp

@@ -48,7 +48,7 @@ void setupSink(toml::table &&sinkTable)
     auto typeStr = sinkTable.at("type").as_string();
 
     bool ok = false;
-    for (auto &typeList : { details::fileStrs, details::rotateStrs, details::dailyStrs, details::nullStrs, details::stdStrs, details::linuxStrs, details::winStrs }) {
+    for (const auto &typeList : { details::fileStrs, details::rotateStrs, details::dailyStrs, details::nullStrs, details::stdStrs, details::linuxStrs, details::winStrs }) {
         if (details::inTypelist(typeStr, typeList)) {
             ok = true;
             break;