Skip to content

compat: Allow Aqua 0.8#106

Merged
JeffreySarnoff merged 1 commit into
JuliaMath:masterfrom
KenoAIStaging:kf/aqua-0.8-compat
Jul 18, 2026
Merged

compat: Allow Aqua 0.8#106
JeffreySarnoff merged 1 commit into
JuliaMath:masterfrom
KenoAIStaging:kf/aqua-0.8-compat

Conversation

@Keno

@Keno Keno commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Aqua 0.6.7's type-piracy/ambiguity detection produces false positives under JuliaLang/julia#61915 (the TypeEq refactor), flagging the package's own inner constructors as piracy because Type{T} is now a TypeEq kind. Aqua 0.8.15 fixes this (it uses Base.isType). Allow Aqua 0.8 so tests pass on recent Julia.

This change was made with the assistance of generative AI (Claude Code).

Aqua 0.6.7's type-piracy/ambiguity detection produces false positives under
JuliaLang/julia#61915 (the TypeEq refactor), flagging the package's own inner
constructors as piracy because Type{T} is now a TypeEq kind. Aqua 0.8.15 fixes
this (it uses Base.isType). Allow Aqua 0.8 so tests pass on recent Julia.

This change was made with the assistance of generative AI (Claude Code).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.74%. Comparing base (8ec62a2) to head (2b6e56d).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   92.74%   92.74%           
=======================================
  Files           3        3           
  Lines         317      317           
=======================================
  Hits          294      294           
  Misses         23       23           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JeffreySarnoff
JeffreySarnoff merged commit 2ce8c11 into JuliaMath:master Jul 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants