fix(loader): drop "2 applied rules" warning

Author: kisenka

lib/exceptions.js

@@ -29,12 +29,6 @@ class ExtractPluginMissingException extends LoaderException {
 
 class InvalidRuntimeException extends LoaderException {}
 
-class SeveralRulesAppliedException extends LoaderException {
-  constructor(resource, rules) {
-    super(`${rules.length} rules applies to ${resource}`);
-  }
-}
-
 class RemainingLoadersInExtractModeException extends LoaderException {
   constructor() {
     super(`Some loaders will be applied after ${PACKAGE_NAME} in extract mode`);
@@ -45,5 +39,4 @@ exports.LoaderException = LoaderException;
 exports.InvalidSvg = InvalidSvg;
 exports.ExtractPluginMissingException = ExtractPluginMissingException;
 exports.InvalidRuntimeException = InvalidRuntimeException;
-exports.SeveralRulesAppliedException = SeveralRulesAppliedException;
 exports.RemainingLoadersInExtractModeException = RemainingLoadersInExtractModeException;

lib/loader.js

@@ -26,10 +26,6 @@ module.exports = function loader(content) {
   const issuer = loaderContext._module && loaderContext._module.issuer;
   const matchedRules = getMatchedRules(resource, getLoadersRules(compiler), issuer);
 
-  if (matchedRules.length > 1 && !compiler.isChild()) {
-    this.emitWarning(new Exceptions.SeveralRulesAppliedException(resource, matchedRules));
-  }
-
   if (!content.includes('<svg')) {
     throw new Exceptions.InvalidSvg(content, matchedRules);
   }

test/loader.test.js

@@ -37,20 +37,6 @@ describe('loader and plugin', () => {
         errors.should.be.lengthOf(1);
         errors[0].error.should.be.instanceOf(Exceptions.InvalidRuntimeException);
       });
-
-      it('should warn if several rules applied to module without issuer applied', async () => {
-        const { warnings } = await compileAndNotReject({
-          entry: './entry',
-          module: rules(
-            svgRule(),
-            rule({ test: /\.svg$/, loader: loaderPath })
-          )
-        });
-
-        // TODO loader applies 2 times so warning also will me emitted 2 times
-        warnings.should.be.lengthOf(2);
-        warnings[0].warning.should.be.instanceOf(Exceptions.SeveralRulesAppliedException);
-      });
     });
 
     it('should allow to use custom runtime generator', async () => {
@@ -65,21 +51,6 @@ describe('loader and plugin', () => {
 
       assets['main.js'].source().should.contain('olala');
     });
-
-    it('should filter rules against issuer', async () => {
-      const { warnings } = await compileAndNotReject({
-        entry: './entry',
-        module: rules(
-          svgRule(),
-          rule({ test: /\.svg$/, loader: loaderPath, issuer: /\.css$/ })
-        )
-      });
-
-      warnings.should.be.lengthOf(isWebpack1 ? 2 : 0);
-      if (isWebpack1) {
-        warnings[0].warning.should.be.instanceOf(Exceptions.SeveralRulesAppliedException);
-      }
-    });
   });
 
   describe('extract mode', () => {