Skip to content

Remove legacy correlate, dot, and multiply from backend - #2183

Merged
AlexanderKalistratov merged 15 commits into
masterfrom
remove_dot_and_multiply_from_backend
Jan 13, 2025
Merged

Remove legacy correlate, dot, and multiply from backend#2183
AlexanderKalistratov merged 15 commits into
masterfrom
remove_dot_and_multiply_from_backend

Conversation

@AlexanderKalistratov

@AlexanderKalistratov AlexanderKalistratov commented Nov 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Removing dot and multiply implementations from backend as no longer needed.

Depends on PR #2183

@AlexanderKalistratov AlexanderKalistratov mentioned this pull request Nov 19, 2024
Merged
@github-actions

github-actions Bot commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2183/index.html

@AlexanderKalistratov
AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch from c0f0457 to 46762fa Compare November 19, 2024 16:04
@AlexanderKalistratov
AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch from 46762fa to 2f51c9e Compare November 20, 2024 02:20
@AlexanderKalistratov
AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch 2 times, most recently from d64c029 to fd2a20d Compare November 20, 2024 03:30
@AlexanderKalistratov AlexanderKalistratov changed the title Remove dot and multiply from backend Remove legacy correlate, dot, and multiply from backend Nov 20, 2024
@AlexanderKalistratov
AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch 2 times, most recently from e3feeef to ca1b3ef Compare November 20, 2024 04:56
vtavana
vtavana reviewed Nov 20, 2024
View reviewed changes
Comment thread dpnp/backend/include/dpnp_iface_fptr.hpp
Comment thread dpnp/dpnp_algo/dpnp_algo.pyx Outdated
Comment thread dpnp/dpnp_algo/dpnp_algo.pxd
@AlexanderKalistratov
AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch from ca1b3ef to 7206e28 Compare November 27, 2024 22:23
@AlexanderKalistratov
AlexanderKalistratov force-pushed the correlate branch 2 times, most recently from fbc94d0 to fa3af10 Compare November 28, 2024 23:09
@antonwolfy antonwolfy mentioned this pull request Dec 4, 2024
Merged
6 tasks
antonwolfy added a commit that referenced this pull request Dec 4, 2024
@antonwolfy
Use SYCL experimental extension for reduction properties (#2211)
ed39ea7 
Recent changes in DPC++ 2025.1 compiler broke DPNP compilation. It seems
the legacy DPC++ compiler behavior was affected by introducing SYCL
experimental extension for reduction properties.

Since the compilation issue occurred for a backend function which will
be removed once #2183 is merged, that PR proposes to temporary w/a the
issue and to reuse the extension for reduction properties, which seems
working.
github-actions Bot added a commit that referenced this pull request Dec 4, 2024
@github-actions
Use SYCL experimental extension for reduction properties (#2211)
a790126 
Recent changes in DPC++ 2025.1 compiler broke DPNP compilation. It seems
the legacy DPC++ compiler behavior was affected by introducing SYCL
experimental extension for reduction properties.

Since the compilation issue occurred for a backend function which will
be removed once #2183 is merged, that PR proposes to temporary w/a the
issue and to reuse the extension for reduction properties, which seems
working. ed39ea7
antonwolfy added a commit that referenced this pull request Dec 5, 2024
@antonwolfy
Use SYCL experimental extension for reduction properties (#2211)
27d6e80 
Recent changes in DPC++ 2025.1 compiler broke DPNP compilation. It seems
the legacy DPC++ compiler behavior was affected by introducing SYCL
experimental extension for reduction properties.

Since the compilation issue occurred for a backend function which will
be removed once #2183 is merged, that PR proposes to temporary w/a the
issue and to reuse the extension for reduction properties, which seems
working.
@AlexanderKalistratov
AlexanderKalistratov force-pushed the correlate branch 2 times, most recently from 936870b to be09e32 Compare December 7, 2024 16:44
@AlexanderKalistratov
AlexanderKalistratov force-pushed the remove_dot_and_multiply_from_backend branch from 7206e28 to 6d17c49 Compare December 7, 2024 17:20
vtavana
vtavana approved these changes Dec 8, 2024
View reviewed changes

@vtavana vtavana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AlexanderKalistratov!

Base automatically changed from correlate to master December 9, 2024 20:56
antonwolfy
antonwolfy reviewed Dec 11, 2024
View reviewed changes
Comment thread dpnp/backend/include/dpnp_gen_2arg_3type_tbl.hpp
Comment thread dpnp/backend/kernels/dpnp_krnl_common.cpp
Comment thread dpnp/backend/kernels/dpnp_krnl_common.cpp
Comment thread dpnp/dpnp_algo/dpnp_algo.pyx
@coveralls

coveralls commented Jan 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 70.895% (+5.8%) from 65.08%
when pulling 525b633 on remove_dot_and_multiply_from_backend
into 659629d on master.

AlexanderKalistratov
AlexanderKalistratov commented Jan 8, 2025
View reviewed changes

@AlexanderKalistratov AlexanderKalistratov left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonwolfy Please re-review

Comment thread dpnp/backend/include/dpnp_gen_2arg_3type_tbl.hpp
Comment thread dpnp/backend/kernels/dpnp_krnl_common.cpp
Comment thread dpnp/backend/kernels/dpnp_krnl_common.cpp
Comment thread dpnp/dpnp_algo/dpnp_algo.pyx
antonwolfy
antonwolfy reviewed Jan 9, 2025
View reviewed changes
Comment thread dpnp/dpnp_algo/dpnp_algo.pxd Outdated
antonwolfy
antonwolfy approved these changes Jan 13, 2025
View reviewed changes

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AlexanderKalistratov LGTM!

@AlexanderKalistratov
AlexanderKalistratov merged commit 44bb068 into master Jan 13, 2025
@AlexanderKalistratov
AlexanderKalistratov deleted the remove_dot_and_multiply_from_backend branch January 13, 2025 21:15
github-actions Bot added a commit that referenced this pull request Jan 13, 2025
@github-actions
Remove legacy correlate, dot, and multiply from backend (#2183)
66c13bc 
Removing `dot` and `multiply` legacy implementations and related legacy utilities from backend as no longer
needed. 44bb068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes
@npolina4 npolina4 Awaiting requested review from npolina4
@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner
+1 more reviewer
@vtavana vtavana vtavana approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexanderKalistratov @coveralls @antonwolfy @vtavana