Update for 2.2.0 - #6567
Conversation
| \li chrome – Download file and then run: `gzip -cd <distribution>.tar.gz | tar xvf -` | ||
| \li wget – | ||
| <div style="margin-left: 2em;"> | ||
| `wget https://github.com/HDFGroup/hdf5/releases/download/${PACKAGEVERSION}/<distribution>.tar.gz`<br> |
There was a problem hiding this comment.
Why is removing https:// necessary?
There was a problem hiding this comment.
@gheber So that it won't try to go to the location which is not valid.
There was a problem hiding this comment.
This strikes me as an "original," albeit somewhat bizarre, approach. What is the underlying engineering problem?
There was a problem hiding this comment.
Do you have other suggestions to avoid reader clicking on an invalid URL?
There was a problem hiding this comment.
I'm still trying to understand the problem we are trying to solve. If we don't want someone to click on a URL, why is there a URL in the first place?
There was a problem hiding this comment.
Because it is a wget example for user to enter the command
There was a problem hiding this comment.
@gheber See the "Methods to obtain (gz file)" section of https://support.hdfgroup.org/documentation/hdf5/latest/rel_spec_2x.html
There was a problem hiding this comment.
@gheber Please see my latest attempt on fixing this.
There was a problem hiding this comment.
Still broken (=not rendering as intended). Prefix the URL with %, i.e.,
...
wget %https://github.com/HDFGroup/hdf5/releases/download/${PACKAGEVERSION}/<distribution>.tar.gz
...
Are you using Claude?
|
I really want us to re-examine the version churn we currently have; it just leads to mistakes down the road. As was the case with which previous version the ABI was being compared to for the reports. Case in point, this has 8 hardcoded version strings across two .dox files, and hdf5_2x.dox is already internally inconsistent today, with some lines pointing at hdf5_2.1.1 while other lines still say 2.1.0. The 2.1.1 patch release updated one of eight. The docs already have the machinery: Doxyfile.in has an empty ALIASES tag and is run through configure_file(... @only) at docs/doxygen/CMakeLists.txt, and CMake already parses the version out of src/H5public.h into HDF5_PACKAGE_VERSION, so the release version is known at configure time, but it just isn't exposed to Doxygen. Please rework this PR to address this; we want to update the docs for free. |
|
Scot, Larry and I talked and we will work on this in the morning. |
| # The previous released version, used for documentation that compares the | ||
| # current release against its predecessor (e.g. ABI/API compatibility | ||
| # reports). This must be updated by hand alongside each version bump. | ||
| set (HDF5_PREVIOUS_VERSION "2.1.1") |
There was a problem hiding this comment.
I think we're going to need a different solution than this, because there's no good value to set this to when a major version bump happens and it also adds another thing to be manually maintained. Seems like we could simply calculate this at build time by taking the current version, doing something special for the case where both the minor and patch versions are 0 (implying a major version bump) and otherwise subtract one from the patch number if not 0, else subtract one from the minor version if not 0.
There was a problem hiding this comment.
@lrknox simplified the PREVIOUS_VER alias for this release, but that will need to be revisited for more complex solution.
|
@brtnfld, we reworked the PR to automate the current release. |
|
Found two follow-up issues after merge, both around the new 1. In But that section ( This predates this PR — the link was already hardcoded to 2. ABI baseline mismatch between the two files
Checked actual release history ( |
|
The reason for the 2.1.0/2.1.1 mess was we did not change all the 2.1.0 occurrences to 2.1.1 when the 2.1.1 was released. There was some complication. We'll work it out. |
No description provided.