feat: Adds example of secure-cloud-function triggered by BigQuery - #26
Merged
gtsorbo merged 31 commits intoMay 18, 2023
Conversation
…s before clou function is ready
amandakarina
force-pushed
the
feat/adds-example-cloud-function-bigquery
branch
3 times, most recently
from
April 26, 2023 15:15
70e4e63 to
0fc6d2d
Compare
amandakarina
force-pushed
the
feat/adds-example-cloud-function-bigquery
branch
6 times, most recently
from
April 27, 2023 19:15
0bb8a66 to
7ebc75d
Compare
amandakarina
force-pushed
the
feat/adds-example-cloud-function-bigquery
branch
from
April 27, 2023 19:22
7ebc75d to
46acfc3
Compare
amandakarina
changed the title
amandakarina
force-pushed
the
feat/adds-example-cloud-function-bigquery
branch
2 times, most recently
from
April 28, 2023 18:09
d4388ea to
cf67805
Compare
amandakarina
force-pushed
the
feat/adds-example-cloud-function-bigquery
branch
from
April 28, 2023 18:29
cf67805 to
7d43542
Compare
Collaborator
Author
|
/gcbrun |
amandakarina
force-pushed
the
feat/adds-example-cloud-function-bigquery
branch
from
May 9, 2023 18:02
b46e4e8 to
f1036c0
Compare
Collaborator
|
@amandakarina Lint errors here. Can you run the link checks locally using |
Collaborator
Author
Hey @prabhu34 These errors requires a new version of Cloud run module, after GoogleCloudPlatform/terraform-google-cloud-run#119 is merged. I will need to change the source to the new version instead of the branch in my fork. |
amandakarina
marked this pull request as ready for review
May 18, 2023 13:16
gtsorbo
approved these changes
May 18, 2023
gtsorbo
left a comment
gtsorbo
left a comment
Contributor
There was a problem hiding this comment.
Minor comments then LGTM
| storage_source = var.storage_source | ||
| service_config = var.service_config | ||
| docker_repository = google_artifact_registry_repository.cloudfunction_repo.id | ||
| # worker_pool = google_cloudbuild_worker_pool.pool.id |
Collaborator
Author
There was a problem hiding this comment.
This will require to be uncommented when the secure web proxy pr is ready.
amandakarina
force-pushed
the
feat/adds-example-cloud-function-bigquery
branch
from
May 18, 2023 18:23
328dc6f to
a7d4673
Compare
amandakarina
force-pushed
the
feat/adds-example-cloud-function-bigquery
branch
from
May 18, 2023 19:33
a7d4673 to
12cff66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks,
This PR adds an usage of secure-cloud-function being triggered by BigQuery.
The linting errors requires a new version of Cloud run module, after GoogleCloudPlatform/terraform-google-cloud-run#119 is merged. I will need to change the source to the new version instead of the branch in my fork.