Skip to content

fix!: bump modules and examples to google provider v7 - #218

Merged
apeabody merged 19 commits into
GoogleCloudPlatform:mainfrom
marcos-leal-cit:fix/bump-modules-google-provider-v7
Apr 27, 2026
Merged

fix!: bump modules and examples to google provider v7#218
apeabody merged 19 commits into
GoogleCloudPlatform:mainfrom
marcos-leal-cit:fix/bump-modules-google-provider-v7

Conversation

@marcos-leal-cit

@marcos-leal-cit marcos-leal-cit commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

Update modules, submodules and examples to use google provider v7.

@marcos-leal-cit
docs: update metadata of modules
2232dc8
@marcos-leal-cit
fix: secure-cloud-function to use v7 and temporary git source for clo…
efb0e97 
…ud_serverless_network
@marcos-leal-cit
fix: secure-cloud-function-core to use google v7
7751772
@marcos-leal-cit
fix: secure-cloud-function-security to use google v7
bdc6936
@marcos-leal-cit
fix: secure-web-proxy to use google v7
858939b
@marcos-leal-cit
fix: cloud-functions to use google v7
0a24f68
@marcos-leal-cit
fix: adjust example cloud_function2_gcs_source to use google v7
8e9325b
@marcos-leal-cit
fix: example cloud_function2_pubsub_trigger to use google v7
46928b7
@marcos-leal-cit
fix: example secure_cloud_function_bigquery_trigger to use google v7
141e285
@marcos-leal-cit
fix: example secure_cloud_function_internal_server to use google v7 w…
47ddbed 
…ith temporary git reference
@marcos-leal-cit
fix: example secure_cloud_function_with_sql to use google v7 with tem…
1b9d697 
…porary git reference
@marcelorobj

marcelorobj commented Apr 16, 2026

Copy link
Copy Markdown

/gcbrun

1 similar comment
@mariammartins

mariammartins commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@mariammartins

mariammartins commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@mariammartins

mariammartins commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@mariammartins

mariammartins commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

1 similar comment
@mariammartins

mariammartins commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@mariammartins

mariammartins commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

5 similar comments
@mariammartins

mariammartins commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@mariammartins

mariammartins commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@mariammartins

mariammartins commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@mariammartins

mariammartins commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@mariammartins

mariammartins commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@marcos-leal-cit
marcos-leal-cit marked this pull request as ready for review April 22, 2026 21:01
apeabody
apeabody requested changes Apr 22, 2026
View reviewed changes

@apeabody apeabody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcos-leal-cit!

Comment thread modules/secure-web-proxy/main.tf Outdated
Comment thread modules/secure-cloud-function/main.tf Outdated
module "cloud_serverless_network" {
source = "GoogleCloudPlatform/cloud-run/google//modules/secure-serverless-net"
version = "~> 0.21.5"
source = "git::https://github.com/marcos-leal-cit/terraform-google-cloud-run.git//modules/secure-serverless-net?ref=8804387cdfd62e074ff3ad529f41b8768b8ddac8"

@apeabody apeabody Apr 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Fix

@marcos-leal-cit marcos-leal-cit Apr 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is related to the bump on cloud-run, PR already opened: GoogleCloudPlatform/terraform-google-cloud-run#460

There are submodules that cloud-run is using that does not support google v7 yet.

@apeabody apeabody Apr 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - Tracking at GoogleCloudPlatform/terraform-google-cloud-run#462

@apeabody apeabody Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to DRAFT as I don't want someone to accidentally merged till these are updated.

Comment thread examples/secure_cloud_function_with_sql/main.tf Outdated
Comment thread examples/secure_cloud_function_internal_server/main.tf Outdated
Comment thread examples/secure_cloud_function_bigquery_trigger/main.tf Outdated
@marcos-leal-cit @apeabody
Apply suggestion from @apeabody
d17bed1 
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
marcos-leal-cit
marcos-leal-cit commented Apr 22, 2026
View reviewed changes

@marcos-leal-cit marcos-leal-cit left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cloud-run modules that cloud-function uses does not suppor google v7. I believe that we need to first have a new release on cloud-run, related to the PR mentioned, and then adjust here.

Comment thread examples/secure_cloud_function_bigquery_trigger/main.tf Outdated
Comment thread examples/secure_cloud_function_internal_server/main.tf Outdated
Comment thread examples/secure_cloud_function_with_sql/main.tf Outdated
Comment thread modules/secure-cloud-function/main.tf Outdated
module "cloud_serverless_network" {
source = "GoogleCloudPlatform/cloud-run/google//modules/secure-serverless-net"
version = "~> 0.21.5"
source = "git::https://github.com/marcos-leal-cit/terraform-google-cloud-run.git//modules/secure-serverless-net?ref=8804387cdfd62e074ff3ad529f41b8768b8ddac8"

@marcos-leal-cit marcos-leal-cit Apr 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is related to the bump on cloud-run, PR already opened: GoogleCloudPlatform/terraform-google-cloud-run#460

There are submodules that cloud-run is using that does not support google v7 yet.

@mariammartins

mariammartins commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@apeabody
apeabody marked this pull request as draft April 22, 2026 21:59
@marcos-leal-cit marcos-leal-cit mentioned this pull request Apr 27, 2026
Merged
@marcos-leal-cit

marcos-leal-cit commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator Author

This PR is blocked until there is a new release on cloud-run repo: GoogleCloudPlatform/terraform-google-cloud-run#462

@marcos-leal-cit
marcos-leal-cit marked this pull request as ready for review April 27, 2026 19:20
@marcos-leal-cit

marcos-leal-cit commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator Author

/gcbrun

2 similar comments
@mariammartins

mariammartins commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

@mariammartins

mariammartins commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

/gcbrun

apeabody
apeabody approved these changes Apr 27, 2026
View reviewed changes

@apeabody apeabody left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcos-leal-cit!

@apeabody
apeabody enabled auto-merge (squash) April 27, 2026 20:17
@apeabody
apeabody disabled auto-merge April 27, 2026 20:17
@apeabody apeabody changed the title fix: bump modules and examples to google provider v7 fix!: bump modules and examples to google provider v7 Apr 27, 2026
@apeabody
apeabody enabled auto-merge (squash) April 27, 2026 20:17
@apeabody
apeabody merged commit b528e8d into GoogleCloudPlatform:main Apr 27, 2026
7 checks passed
@release-please release-please Bot mentioned this pull request Apr 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeabody apeabody apeabody approved these changes
@ayushmjain ayushmjain Awaiting requested review from ayushmjain ayushmjain is a code owner
@krprabhat-eng krprabhat-eng Awaiting requested review from krprabhat-eng krprabhat-eng is a code owner
@prabhu34 prabhu34 Awaiting requested review from prabhu34 prabhu34 is a code owner
@q2w q2w Awaiting requested review from q2w q2w is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcos-leal-cit @marcelorobj @mariammartins @apeabody