review feedback

Author: julienledem

java/vector/src/main/java/org/apache/arrow/vector/complex/MapVector.java

@@ -44,8 +44,6 @@
 import com.google.common.collect.Ordering;
 import com.google.common.primitives.Ints;
 
-import io.netty.buffer.ArrowBuf;
-
 public class MapVector extends AbstractMapVector {
   //private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(MapVector.class);
 
@@ -115,15 +113,6 @@ public int getBufferSizeFor(final int valueCount) {
     return (int) bufferSize;
   }
 
-  @Override
-  public ArrowBuf[] getBuffers(boolean clear) {
-//    int expectedSize = getBufferSize();
-//    int actualSize   = super.getBufferSize();
-//
-//    Preconditions.checkArgument(expectedSize == actualSize, expectedSize + " != " + actualSize);
-    return super.getBuffers(clear);
-  }
-
   @Override
   public TransferPair getTransferPair(BufferAllocator allocator) {
     return new MapTransferPair(this, new MapVector(name, allocator, callBack), false);

java/vector/src/main/java/org/apache/arrow/vector/complex/NullableMapVector.java

@@ -235,6 +235,17 @@ public void setValueCount(int valueCount) {
       bits.getMutator().setValueCount(valueCount);
     }
 
+    @Override
+    public void generateTestData(int valueCount){
+      super.generateTestData(valueCount);
+      bits.getMutator().generateTestDataAlt(valueCount);
+    }
+
+    @Override
+    public void reset(){
+      bits.getMutator().setValueCount(0);
+    }
+
   }
 
   @Override