oxlint

Author: MaxNumerique

.oxlintrc.json

@@ -25,7 +25,23 @@
     "eslint/id-length": [
       "error",
       {
-        "exceptions": ["x", "y", "z", "i", "j", "k", "id", "ID", "fs", "os", "_"],
+        "exceptions": [
+          "x",
+          "y",
+          "z",
+          "i",
+          "j",
+          "k",
+          "r",
+          "g",
+          "b",
+          "a",
+          "id",
+          "ID",
+          "fs",
+          "os",
+          "_"
+        ],
         "min": 3
       }
     ],
@@ -124,7 +140,8 @@
         "vitest/prefer-to-be-falsy": "off",
         "vitest/require-test-timeout": "warn",
         "vitest/prefer-importing-vitest-globals": "off",
-        "jest/consistent-test-it": ["error", { "fn": "test", "withinDescribe": "test" }]
+        "jest/consistent-test-it": ["error", { "fn": "test", "withinDescribe": "test" }],
+        "vitest/prefer-spy-on": "off"
       }
     },
     {

tests/integration/stores/viewer.nuxt.test.js

@@ -15,16 +15,16 @@ const CONNECT_TIMEOUT = 25_000;
 
 let projectFolderPath = "";
 
-beforeAll(async () => {
-  setupActivePinia();
-  ({ projectFolderPath } = await runMicroservices());
-});
+describe("viewer Store", () => {
+  beforeAll(async () => {
+    setupActivePinia();
+    ({ projectFolderPath } = await runMicroservices());
+  });
 
-afterAll(async () => {
-  await cleanupBackend(projectFolderPath);
-});
+  afterAll(async () => {
+    await cleanupBackend(projectFolderPath);
+  });
 
-describe("Viewer Store", () => {
   describe("actions", () => {
     describe("ws_connect", () => {
       test(
@@ -52,15 +52,13 @@ describe("Viewer Store", () => {
     describe("request", () => {
       test(
         "request",
-        () => {
+        async () => {
           const schema = opengeodeweb_viewer_schemas.opengeodeweb_viewer.viewer.render;
           const viewerStore = useViewerStore();
           const timeout = 1;
           const params = {};
-          expect(() =>
-            viewerStore
-              .request(schema, params, {}, timeout)
-              .rejects.toThrow(`${schema.$id}: Timed out after ${timeout}ms, ${schema} ${params}`),
+          await expect(viewerStore.request(schema, params, {}, timeout)).rejects.toThrow(
+            `${schema.$id}: Timed out after ${timeout}ms, ${schema} ${params}`,
           );
         },
         CONNECT_TIMEOUT,

tests/unit/components/CrsSelector.nuxt.test.js

@@ -13,14 +13,14 @@ const FIRST_INDEX = 0;
 let pinia = undefined;
 let geodeStore = undefined;
 
-beforeEach(() => {
-  pinia = setupActivePinia();
-  geodeStore = useGeodeStore();
-  geodeStore.base_url = "";
-});
+describe("crs selector", () => {
+  beforeEach(() => {
+    pinia = setupActivePinia();
+    geodeStore = useGeodeStore();
+    geodeStore.base_url = "";
+  });
 
-describe(CrsSelector, () => {
-  test(`Default behavior`, async () => {
+  test("default behavior", async () => {
     const crs_list = [
       {
         authority: "EPSG",
@@ -31,9 +31,7 @@ describe(CrsSelector, () => {
 
     // Mock geodeStore.request instead of registerEndpoint
     geodeStore.request = vi.fn((schema, params, callbacks) => {
-      if (callbacks?.response_function) {
-        callbacks.response_function({ crs_list });
-      }
+      callbacks.response_function({ crs_list });
       return Promise.resolve({ crs_list });
     });
 
@@ -50,7 +48,7 @@ describe(CrsSelector, () => {
     await input.trigger("click");
     expect(wrapper.emitted()).toHaveProperty("update_values");
     expect(wrapper.emitted().update_values).toHaveLength(EXPECTED_LENGTH);
-    expect(wrapper.emitted().update_values[FIRST_INDEX][FIRST_INDEX]).toEqual({
+    expect(wrapper.emitted().update_values[FIRST_INDEX][FIRST_INDEX]).toStrictEqual({
       [key_to_update]: crs_list[FIRST_INDEX],
     });
   });

tests/unit/components/ExtensionSelector.nuxt.test.js

@@ -19,21 +19,21 @@ const schema = schemas.opengeodeweb_back.geode_objects_and_output_extensions;
 const pinia = setupActivePinia();
 const geodeStore = useGeodeStore();
 
-beforeEach(() => {
-  geodeStore.base_url = "";
+describe("extension selector", () => {
+  beforeEach(() => {
+    geodeStore.base_url = "";
 
-  geodeStore.request = vi.fn(() => {
-    const response = {
-      geode_objects_and_output_extensions: {
-        BRep: { msh: { is_saveable: true } },
-      },
-    };
-    return Promise.resolve(response);
+    geodeStore.request = vi.fn(() => {
+      const response = {
+        geode_objects_and_output_extensions: {
+          BRep: { msh: { is_saveable: true } },
+        },
+      };
+      return Promise.resolve(response);
+    });
   });
-});
 
-describe(ExtensionSelector, () => {
-  test(`Select geode_object & extension`, async () => {
+  test("select geode_object & extension", async () => {
     const output_geode_object = "BRep";
     const output_extension = "msh";
 

tests/unit/components/FeedBack/ErrorsBanner.nuxt.test.js

@@ -9,9 +9,10 @@ import { useFeedbackStore } from "@ogw_front/stores/feedback";
 
 const CALLED_TIMES = 1;
 
-describe(FeedBackErrorBanner, () => {
+describe("feedback error banner", () => {
   const pinia = setupActivePinia();
-  test(`Test reload`, async () => {
+
+  test("reload", async () => {
     const wrapper = mount(FeedBackErrorBanner, {
       global: {
         plugins: [vuetify, pinia],
@@ -26,7 +27,7 @@ describe(FeedBackErrorBanner, () => {
     expect(reload_spy).toHaveBeenCalledTimes(CALLED_TIMES);
   });
 
-  test(`Test delete error`, async () => {
+  test("delete error", async () => {
     const wrapper = mount(FeedBackErrorBanner, {
       global: {
         plugins: [vuetify, pinia],

tests/unit/components/FeedBack/Snackers.nuxt.test.js

@@ -10,8 +10,8 @@ import { useFeedbackStore } from "@ogw_front/stores/feedback";
 
 vi.stubGlobal("visualViewport", new EventTarget());
 
-describe(FeedBackSnackers, () => {
-  test(`Test delete error`, async () => {
+describe("feedback snackers", () => {
+  test("delete feedback", async () => {
     const pinia = setupActivePinia();
     const feedbackStore = useFeedbackStore();
     feedbackStore.$patch({
@@ -41,9 +41,9 @@ describe(FeedBackSnackers, () => {
       },
     );
 
-    expect(feedbackStore.feedbacks.length).toBe(1);
+    expect(feedbackStore.feedbacks).toHaveLength(1);
     const v_btn = await wrapper.findComponent(components.VBtn);
     await v_btn.trigger("click");
-    expect(feedbackStore.feedbacks.length).toBe(0);
+    expect(feedbackStore.feedbacks).toHaveLength(0);
   });
 });

tests/unit/components/FileSelector.nuxt.test.js

@@ -18,12 +18,12 @@ const SECOND_INDEX = 1;
 const allowed_files_schema = schemas.opengeodeweb_back.allowed_files;
 const upload_file_schema = schemas.opengeodeweb_back.upload_file;
 
-describe(FileSelector, () => {
+describe("file selector", () => {
   const pinia = setupActivePinia();
   const geodeStore = useGeodeStore();
   geodeStore.base_url = "";
 
-  test(`Select file`, async () => {
+  test("select file", async () => {
     registerEndpoint(allowed_files_schema.$id, {
       method: allowed_files_schema.methods[FIRST_INDEX],
       handler: () => ({
@@ -58,13 +58,13 @@ describe(FileSelector, () => {
     await flushPromises();
     expect(wrapper.emitted()).toHaveProperty("update_values");
     expect(wrapper.emitted().update_values).toHaveLength(EXPECTED_LENGTH);
-    expect(wrapper.emitted().update_values[FIRST_INDEX][FIRST_INDEX]).toEqual({
+    expect(wrapper.emitted().update_values[FIRST_INDEX][FIRST_INDEX]).toStrictEqual({
       files,
       auto_upload,
     });
   });
 
-  describe(FileSelector, () => {
+  describe("file selector", () => {
     registerEndpoint(allowed_files_schema.$id, {
       method: allowed_files_schema.methods[FIRST_INDEX],
       handler: () => ({
@@ -76,8 +76,8 @@ describe(FileSelector, () => {
       method: upload_file_schema.methods[SECOND_INDEX],
       handler: () => ({}),
     });
-
     const files = [new File(["fake_file"], "fake_file.txt")];
+
     test("auto_upload true", async () => {
       const wrapper = await mountSuspended(FileSelector, {
         global: {
@@ -91,10 +91,10 @@ describe(FileSelector, () => {
       });
 
       await flushPromises();
-      expect(wrapper.componentVM.files).toEqual(files);
+      expect(wrapper.componentVM.files).toStrictEqual(files);
       expect(wrapper.emitted()).toHaveProperty("update_values");
       expect(wrapper.emitted().update_values).toHaveLength(EXPECTED_LENGTH);
-      expect(wrapper.emitted().update_values[FIRST_INDEX][FIRST_INDEX]).toEqual({
+      expect(wrapper.emitted().update_values[FIRST_INDEX][FIRST_INDEX]).toStrictEqual({
         files,
         auto_upload: false,
       });
@@ -115,7 +115,7 @@ describe(FileSelector, () => {
       await flushPromises();
 
       const file_uploader = wrapper.findComponent(FileUploader);
-      expect(wrapper.vm.files).toEqual(files);
+      expect(wrapper.vm.files).toStrictEqual(files);
       const upload_files = vi.spyOn(file_uploader.vm, "upload_files");
       expect(upload_files).not.toHaveBeenCalled();
     });

tests/unit/components/FileUploader.nuxt.test.js

@@ -15,7 +15,7 @@ const SECOND_INDEX = 1;
 
 const upload_file_schema = schemas.opengeodeweb_back.upload_file;
 
-describe(FileUploader, () => {
+describe("file uploader", () => {
   const pinia = setupActivePinia();
   const geodeStore = useGeodeStore();
   geodeStore.base_url = "";
@@ -31,8 +31,8 @@ describe(FileUploader, () => {
 
   const files = [new File(["fake_file"], "fake_file.txt")];
 
-  describe(`Upload file`, () => {
-    test(`prop auto_upload false`, async () => {
+  describe("upload file", () => {
+    test("prop auto_upload false", async () => {
       const wrapper = await mountSuspended(FileUploader, {
         global: {
           plugins: [vuetify, pinia],
@@ -51,7 +51,7 @@ describe(FileUploader, () => {
       await v_btn.trigger("click");
       await flushPromises();
       await flushPromises();
-      expect(wrapper.emitted().files_uploaded[FIRST_INDEX][FIRST_INDEX]).toEqual(files);
+      expect(wrapper.emitted().files_uploaded[FIRST_INDEX][FIRST_INDEX]).toStrictEqual(files);
     });
 
     test(`prop auto_upload true`, async () => {
@@ -62,7 +62,7 @@ describe(FileUploader, () => {
         props: { multiple: false, accept: "*.txt", files, auto_upload: true },
       });
       await flushPromises();
-      expect(wrapper.emitted().files_uploaded[FIRST_INDEX][FIRST_INDEX]).toEqual(files);
+      expect(wrapper.emitted().files_uploaded[FIRST_INDEX][FIRST_INDEX]).toStrictEqual(files);
     });
   });
 });

tests/unit/components/Inspector/InspectionButton.nuxt.test.js

@@ -9,12 +9,12 @@ import { setupActivePinia, vuetify } from "@ogw_tests/utils";
 import InspectorInspectionButton from "@ogw_front/components/Inspector/InspectionButton";
 import { useGeodeStore } from "@ogw_front/stores/geode";
 
-describe("Inspector/InspectionButton", () => {
+describe("inspector inspection button", () => {
   const pinia = setupActivePinia();
   const geodeStore = useGeodeStore();
   geodeStore.base_url = "";
 
-  test(`Test with issues`, async () => {
+  test("with issues", async () => {
     const inspection_result = {
       title: "Brep inspection",
       nb_issues: 3,
@@ -31,28 +31,18 @@ describe("Inspector/InspectionButton", () => {
         },
       ],
     };
-
-    geodeStore.request = vi.fn((_schema, params, callbacks) => {
-      if (callbacks?.response_function) {
-        callbacks.response_function({
-          inspection_result,
-        });
-      }
-      return Promise.resolve({
-        inspection_result,
-      });
+    geodeStore.request = vi.fn((_schema, _params, callbacks) => {
+      callbacks?.response_function?.({ inspection_result });
+      return Promise.resolve({ inspection_result });
     });
-
     const geode_object_type = "BRep";
     const filename = "test.txt";
-
     const wrapper = await mountSuspended(InspectorInspectionButton, {
       global: {
         plugins: [vuetify, pinia],
       },
       props: { geode_object_type, filename },
     });
-
     expect(wrapper.exists()).toBe(true);
     const v_btn = await wrapper.findComponent(components.VBtn);
     await v_btn.trigger("click");

tests/unit/components/Inspector/ResultPanel.nuxt.test.js

@@ -6,8 +6,8 @@ import { mountSuspended } from "@nuxt/test-utils/runtime";
 import InspectorResultPanel from "@ogw_front/components/Inspector/ResultPanel";
 import { vuetify } from "@ogw_tests/utils";
 
-describe("Inspector/ResultPanel", () => {
-  test(`Test with issues`, async () => {
+describe("inspector result panel", () => {
+  test("with issues", async () => {
     const inspection_result = [
       {
         title: "Brep inspection",
@@ -33,7 +33,7 @@ describe("Inspector/ResultPanel", () => {
     );
   });
 
-  test(`Test without issues`, async () => {
+  test("without issues", async () => {
     const inspection_result = [
       {
         title: "Brep inspection",