Cleanup

Author: Genbox

FastData.slnx

@@ -38,6 +38,7 @@
         <File Path="Docs/Architecture/EarlyExits.md" />
         <File Path="Docs/Architecture/Generators.md" />
         <File Path="Docs/Architecture/Hashing.md" />
+        <File Path="Docs/Architecture/StringEquality.md" />
     </Folder>
     <Folder Name="/_Docs/Development/">
         <File Path="Docs/Development/CreatingEarlyExits.md" />

Src/FastData.BenchmarkHarness.Runner/Application.cs

@@ -33,7 +33,7 @@ public async Task<int> RunAsync(Settings settings, CancellationToken cancellatio
             settings.Workload,
             settings.MaxError).ToArray();
 
-        ITestData[] benchmarkData = [..structureBenchmarks, ..earlyExitBenchmarks];
+        ITestData[] benchmarkData = [.. structureBenchmarks, .. earlyExitBenchmarks];
         ResultStore resultStore = new ResultStore(settings.ResultsDirectory);
 
         return settings.Mode switch
@@ -154,7 +154,7 @@ private static (string Label, string Value)[] GetExtraRows(Settings settings)
             ("Loop", $"Warmup: {settings.WarmupCount.ToString(NumberFormatInfo.InvariantInfo)}, Samples: {settings.MinSampleCount.ToString(NumberFormatInfo.InvariantInfo)}-{settings.MaxSampleCount.ToString(NumberFormatInfo.InvariantInfo)}, Target: {settings.TargetIterationTimeMs.ToString(NumberFormatInfo.InvariantInfo)}ms, MaxError: {settings.MaxError.ToString(NumberFormatInfo.InvariantInfo)}%")
         ];
 
-        return settings.Debug ? [..rows, ("Debug", "Enabled")] : rows;
+        return settings.Debug ? [.. rows, ("Debug", "Enabled")] : rows;
     }
 
     private static int WriteNoBenchmarksMatched(Settings settings)

Src/FastData.BenchmarkHarness.Runner/Environment/RunEnvironment.cs

@@ -42,12 +42,12 @@ public static RunEnvironment Apply(EnvironmentSettings settings, (string Label,
 
         if (!WindowsPowerPlan.IsSupported)
         {
-            ConsoleOutput.WriteBenchmarkSetup([osRow, cpuCountRow, ("Power plan", "skipped (not Windows)"), cpuRow, ..extraRows]);
+            ConsoleOutput.WriteBenchmarkSetup([osRow, cpuCountRow, ("Power plan", "skipped (not Windows)"), cpuRow, .. extraRows]);
             return new RunEnvironment(null);
         }
 
         WindowsPowerPlanState state = WindowsPowerPlan.Apply(settings.PowerPlan);
-        ConsoleOutput.WriteBenchmarkSetup([osRow, cpuCountRow, ("Power plan", state.PowerPlanDisplay), ("Processor AC", state.ProcessorAcDisplay), cpuRow, ..extraRows]);
+        ConsoleOutput.WriteBenchmarkSetup([osRow, cpuCountRow, ("Power plan", state.PowerPlanDisplay), ("Processor AC", state.ProcessorAcDisplay), cpuRow, .. extraRows]);
         return new RunEnvironment(state);
     }
 }

Src/FastData.Benchmarks/Benchmarks/DeduplicationBenchmarks.cs

@@ -11,20 +11,20 @@ public class DeduplicationBenchmarks
     private const int RangeSize = 200;
     private const int BitSetCount = 16_384;
     private const int BitSetRangeStep = 97;
-
-    private byte[] _rangeUInt8Keys = null!;
-    private sbyte[] _rangeInt8Keys = null!;
+    private int[] _bitSetInt32Keys = null!;
+    private long[] _bitSetInt64Keys = null!;
+    private uint[] _bitSetUInt32Keys = null!;
+    private ulong[] _bitSetUInt64Keys = null!;
     private char[] _rangeCharKeys = null!;
     private short[] _rangeInt16Keys = null!;
-    private ushort[] _rangeUInt16Keys = null!;
     private int[] _rangeInt32Keys = null!;
-    private uint[] _rangeUInt32Keys = null!;
     private long[] _rangeInt64Keys = null!;
+    private sbyte[] _rangeInt8Keys = null!;
+    private ushort[] _rangeUInt16Keys = null!;
+    private uint[] _rangeUInt32Keys = null!;
     private ulong[] _rangeUInt64Keys = null!;
-    private int[] _bitSetInt32Keys = null!;
-    private uint[] _bitSetUInt32Keys = null!;
-    private long[] _bitSetInt64Keys = null!;
-    private ulong[] _bitSetUInt64Keys = null!;
+
+    private byte[] _rangeUInt8Keys = null!;
 
     [GlobalSetup]
     public void Setup()
@@ -45,7 +45,7 @@ public void Setup()
 
         for (int i = 0; i < RangeCount; i++)
         {
-            int value = i * 997 % RangeSize;
+            int value = (i * 997) % RangeSize;
             _rangeUInt8Keys[i] = (byte)value;
             _rangeInt8Keys[i] = (sbyte)(value - 100);
             _rangeCharKeys[i] = (char)value;
@@ -59,7 +59,7 @@ public void Setup()
 
         for (int i = 0; i < BitSetCount; i++)
         {
-            int value = i % (BitSetCount / 2) * BitSetRangeStep;
+            int value = (i % (BitSetCount / 2)) * BitSetRangeStep;
             _bitSetInt32Keys[i] = value - 100_000;
             _bitSetUInt32Keys[i] = (uint)value + 1_000_000u;
             _bitSetInt64Keys[i] = value - 100_000L;

Src/FastData.Benchmarks/Benchmarks/DeduplicationDispatchBenchmarks.cs

@@ -21,7 +21,7 @@ public void Setup()
 
         for (int i = 0; i < Count; i++)
         {
-            int value = i * 997 % 200;
+            int value = (i * 997) % 200;
             _byteKeys[i] = (byte)value;
             _uint16Keys[i] = (ushort)(10000 + value);
         }

Src/FastData.Benchmarks/Benchmarks/IntegerEncodingBenchmarks.cs

@@ -12,8 +12,8 @@ namespace Genbox.FastData.Benchmarks.Benchmarks;
 public class IntegerEncodingBenchmarks
 {
     private readonly byte[] _encoded = new byte[10 * 4096];
-    private readonly int[] _offsets = new int[4096];
     private readonly int[] _lengths = new int[4096];
+    private readonly int[] _offsets = new int[4096];
     private IIntegerEncoding _encoding = null!;
     private ulong[] _values = null!;
 

Src/FastData.Benchmarks/Benchmarks/KeyAnalyzerBenchmarks.cs

@@ -9,15 +9,15 @@ public class KeyAnalyzerBenchmarks
 {
     private readonly string[] _data;
 
-    [Params(GeneratorEncoding.Utf16CodeUnits, GeneratorEncoding.Utf8Bytes)]
-    public GeneratorEncoding Encoding { get; set; }
-
     public KeyAnalyzerBenchmarks()
     {
         Random rng = new Random(42);
         _data = Enumerable.Range(1, 100).Select(_ => TestHelper.GenerateRandomString(rng, 50)).ToArray();
     }
 
+    [Params(GeneratorEncoding.Utf16CodeUnits, GeneratorEncoding.Utf8Bytes)]
+    public GeneratorEncoding Encoding { get; set; }
+
     [Benchmark]
     public object GetStringProperties() => KeyAnalyzer.GetStringProperties(_data, false, Encoding);
 }

Src/FastData.Benchmarks/Benchmarks/NumericEarlyExitBenchmarks.cs

@@ -8,16 +8,16 @@ namespace Genbox.FastData.Benchmarks.Benchmarks;
 [SuppressMessage("ReSharper", "FieldCanBeMadeReadOnly.Local")]
 public class NumericEarlyExitBenchmarks
 {
-    private int _min = 3;
-    private int _max = 42;
-    private int _value = 7;
-    private byte _byteMin = 42;
     private byte _byteMax = 100;
+    private byte _byteMin = 42;
     private byte _byteValue = 41;
-    private sbyte _sbyteMin = -10;
+    private int _max = 42;
+    private int _min = 3;
     private sbyte _sbyteMax = 20;
+    private sbyte _sbyteMin = -10;
     private sbyte _sbyteValue = -11;
     private Vector256<int> _simdSet = Vector256.Create(3, 5, 7, 11, 13, 17, 19, 23);
+    private int _value = 7;
 
     [Benchmark]public bool ValueRange() => _value < _min || _value > _max;
 

Src/FastData.Benchmarks/Benchmarks/SimulatorBenchmarks.cs

@@ -19,8 +19,8 @@ public class SimulatorBenchmarks
     private BruteForceStringHash _bruteForceHash = null!;
     private string[] _keys = null!;
     private StringKeyProperties _properties = null!;
-    private IStringHash _stringHash = null!;
     private Simulator _simulator = null!;
+    private IStringHash _stringHash = null!;
 
     [Params(32, 256, 1000, 10000)]
     public int Count { get; set; }
@@ -33,7 +33,7 @@ public void Setup()
         for (int i = 0; i < _keys.Length; i++)
             _keys[i] = $"key-{i:D8}-abcdefghijklmnopqrstuvwxyz";
 
-        _stringHash = DefaultStringHash.GetInstance(GeneratorEncoding.Utf8Bytes, false);
+        _stringHash = DefaultStringHash.GetInstance(GeneratorEncoding.Utf8Bytes);
         _properties = KeyAnalyzer.GetStringProperties(_keys, false, GeneratorEncoding.Utf8Bytes);
         _bruteForceHash = new BruteForceStringHash(new ArraySegment(0, 8, Alignment.Left), Mix, static hash => hash);
         _simulator = new Simulator(_keys, GeneratorEncoding.Utf8Bytes);

Src/FastData.Benchmarks/Benchmarks/StringEarlyExitBenchmarks.cs

@@ -7,13 +7,13 @@ namespace Genbox.FastData.Benchmarks.Benchmarks;
 [SuppressMessage("ReSharper", "FieldCanBeMadeReadOnly.Local")]
 public class StringEarlyExitBenchmarks
 {
-    private string _value = "hello world";
-    private int _min = 3;
-    private int _max = 42;
     private ulong[] _bitset = [2828, 4848];
     private ulong _firstLow = 60;
     private ulong _lastLow = 60;
+    private int _max = 42;
+    private int _min = 3;
     private ulong _stringMask = 0xFF93FF93FF9AFF97UL;
+    private string _value = "hello world";
 
     [Benchmark]public bool LengthEqual() => _value.Length != 49;