Fail build on error

Author: meson800

.github/workflows/build_helper.sh

@@ -1,15 +1,16 @@
 #########################################################################
 # Modified from Michael Altfield's work:
 # https://tech.michaelaltfield.net/2020/07/23/sphinx-rtd-github-pages-2/
-######################################################################### 
+#########################################################################
+FAILED=0
 echo "::group::Build env info"
 pwd
 ls -lah
 echo "::endgroup::"
 export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct)
 
 # make a new temp dir which will be our GitHub Pages docroot
-docroot=`mktemp -d`
+docroot=$(mktemp -d)
 
 export REPO_NAME="${GITHUB_REPOSITORY##*/}"
 
@@ -18,11 +19,11 @@ export REPO_NAME="${GITHUB_REPOSITORY##*/}"
 ##############
 
 # get a list of branches, excluding 'HEAD' and 'gh-pages'
-versions="`git for-each-ref '--format=%(refname:lstrip=-1)' refs/remotes/origin/ refs/tags | grep -viE '^(HEAD|gh-pages)$'`"
+versions="$(git for-each-ref '--format=%(refname:lstrip=-1)' refs/remotes/origin/ refs/tags | grep -viE '^(HEAD|gh-pages)$')"
 for current_version in ${versions}; do
    # make the current language available to conf.py
    export current_version
-   git checkout ${current_version} >/dev/null 2>/dev/null
+   git checkout "${current_version}" >/dev/null 2>/dev/null
 
 
    echo "::group::Pre-build info for ${current_version}"
@@ -40,7 +41,7 @@ for current_version in ${versions}; do
    ##########
    # BUILDS #
    ##########
-   python ./build.py --latex --parallel --force-rebuild --emit-gh-annotations
+   python ./build.py --latex --parallel --force-rebuild --emit-gh-annotations || FAILED=1
 
    # HTML #
 
@@ -66,7 +67,7 @@ git checkout latest
 git config --global user.name "${GITHUB_ACTOR}"
 git config --global user.email "${GITHUB_ACTOR}@users.noreply.github.com"
 
-pushd "${docroot}"
+pushd "${docroot}" || exit
 
 # don't bother maintaining history; just generate fresh
 git init
@@ -109,14 +110,14 @@ EOF
 git add .
 
 # commit all the new files
-msg="Updating Docs for commit ${GITHUB_SHA} made on `date -d"@${SOURCE_DATE_EPOCH}" --iso-8601=seconds` from ${GITHUB_REF} by ${GITHUB_ACTOR}"
+msg="Updating Docs for commit ${GITHUB_SHA} made on $(date -d"@${SOURCE_DATE_EPOCH}" --iso-8601=seconds) from ${GITHUB_REF} by ${GITHUB_ACTOR}"
 git commit -am "${msg}"
 
 # overwrite the contents of the gh-pages branch on our github.com repo
 git push deploy gh-pages --force
 echo "::endgroup::"
 
-popd # return to main repo sandbox root
+popd || exit # return to main repo sandbox root
 
-# exit cleanly
-exit 0
+# exit based on FAILED state
+exit $FAILED

build.py

@@ -244,3 +244,8 @@ def summarize_latex_logfile(logs):
         # see https://unix.stackexchange.com/questions/274428/how-do-i-reduce-the-size-of-a-pdf-file-that-contains-images
         subprocess.run(['gs', '-sDEVICE=pdfwrite', '-dPDFSETTINGS=/ebook', '-q', '-o', 'output/html/galloway_lab_protocols.pdf', 'output/latex/latex/gallowaylabprotocols.pdf'])
         #shutil.copyfile('output/latex/latex/gallowaylabprotocols.pdf', 'output/html/galloway_lab_protocols.pdf')
+    
+    if args.emit_gh_annotations:
+        for annotation in gh_annotations:
+            if annotation.annotation_level == AnnotationLevel.ERROR:
+                sys.exit(1)