Skip to content

feat: always show pin/unpin as action - #561

Merged
naveensingh merged 2 commits into
mainfrom
naveensingh/pin-unpin
Oct 15, 2025
Merged

feat: always show pin/unpin as action#561
naveensingh merged 2 commits into
mainfrom
naveensingh/pin-unpin

Conversation

@naveensingh

@naveensingh naveensingh commented Oct 15, 2025

Copy link
Copy Markdown
Member

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

  • Added unpin icon and updated the pin icon.
  • Updated the unpin condition to only show when all selected items are already pinned. Previously, both pin and unpin options showed up when selecting both pinned and unpinned conversations.
  • Update the menu layout to always show pin/unpin as action buttons.

Tests performed

  • Pinning/unpinning convos

Closes the following issue(s)

  • Not tracked. It's ok to bend the rules sometimes.

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@naveensingh
naveensingh merged commit 2ed6dd0 into main Oct 15, 2025
3 checks passed
@naveensingh
naveensingh deleted the naveensingh/pin-unpin branch October 15, 2025 15:42
@fossifybot fossifybot Bot mentioned this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant