From 584cc42b51f9b836cd06785628b7bb61193867b8 Mon Sep 17 00:00:00 2001 From: Edoardo Abati <29585319+EdAbati@users.noreply.github.com> Date: Sun, 14 Apr 2024 13:06:18 +0200 Subject: [PATCH 1/2] improve import error polars --- .../components/converters/polars.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/dataframes_haystack/components/converters/polars.py b/src/dataframes_haystack/components/converters/polars.py index eb3cbd4..9ffeb1c 100644 --- a/src/dataframes_haystack/components/converters/polars.py +++ b/src/dataframes_haystack/components/converters/polars.py @@ -2,12 +2,14 @@ from haystack import Document, component, logging from haystack.components.converters.utils import normalize_metadata -from haystack.lazy_imports import LazyImport -logger = logging.getLogger(__name__) - -with LazyImport(message="Run 'pip install \"dataframes-haystack[polars]\"'") as polars_import: +try: import polars as pl +except ImportError as e: + msg = "`polars` is not installed. Please run 'pip install \"dataframes-haystack[polars]\"'" + raise ImportError(msg) from e + +logger = logging.getLogger(__name__) @component From b1de54943add7ad406ae1da0602b87d43c4046e1 Mon Sep 17 00:00:00 2001 From: Edoardo Abati <29585319+EdAbati@users.noreply.github.com> Date: Sun, 14 Apr 2024 13:16:03 +0200 Subject: [PATCH 2/2] updated badges --- .github/workflows/test.yml | 2 +- README.md | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index fd85b9e..496de8a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,4 +1,4 @@ -name: 🧐 Run tests +name: 🔎 Run Tests on: push: diff --git a/README.md b/README.md index 723f2bb..158e463 100644 --- a/README.md +++ b/README.md @@ -1,12 +1,14 @@ # Dataframes Haystack -[![PyPI - Version](https://img.shields.io/pypi/v/dataframes-haystack.svg)](https://pypi.org/project/dataframes-haystack) +[![PyPI - Version](https://img.shields.io/pypi/v/dataframes-haystack)](https://pypi.org/project/dataframes-haystack) [![PyPI - Python Version](https://img.shields.io/pypi/pyversions/dataframes-haystack?logo=python&logoColor=white)](https://pypi.org/project/dataframes-haystack) -[![PyPI - License](https://img.shields.io/pypi/l/dataframes-haystack.svg)](https://pypi.org/project/dataframes-haystack) +[![PyPI - License](https://img.shields.io/pypi/l/dataframes-haystack)](https://pypi.org/project/dataframes-haystack) [![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black) [![Ruff](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json)](https://github.com/astral-sh/ruff) + +[![GH Actions Tests](https://github.com/EdAbati/dataframes-haystack/actions/workflows/test.yml/badge.svg)](https://github.com/EdAbati/dataframes-haystack/actions/workflows/test.yml) [![pre-commit.ci status](https://results.pre-commit.ci/badge/github/EdAbati/dataframes-haystack/main.svg)](https://results.pre-commit.ci/latest/github/EdAbati/dataframes-haystack/main) -----