cache arg implementation in CLI (dotnet#280)

* cache implementation

* corrected the null case

* added tests for all cases

Author: srsaggam

src/mlnet.Test/CommandLineTests.cs

@@ -172,5 +172,63 @@ public void TestCommandLineArgsMutuallyExclusiveArgsTest()
             Assert.IsFalse(parsingSuccessful);
 
         }
+
+        [TestMethod]
+        public void CacheArgumentTest()
+        {
+            bool parsingSuccessful = false;
+            var trainDataset = Path.GetTempFileName();
+            var testDataset = Path.GetTempFileName();
+            var labelName = "Label";
+            var cache = "on";
+
+            // Create handler outside so that commandline and the handler is decoupled and testable.
+            var handler = CommandHandler.Create<NewCommandSettings>(
+                (opt) =>
+                {
+                    parsingSuccessful = true;
+                    Assert.AreEqual(opt.MlTask, "binary-classification");
+                    Assert.AreEqual(opt.Dataset, trainDataset);
+                    Assert.AreEqual(opt.LabelColumnName, labelName);
+                    Assert.AreEqual(opt.Cache, cache);
+                });
+
+            var parser = new CommandLineBuilder()
+                        // Parser
+                        .AddCommand(CommandDefinitions.New(handler))
+                        .UseDefaults()
+                        .Build();
+
+            // valid cache test
+            string[] args = new[] { "new", "--ml-task", "binary-classification", "--dataset", trainDataset, "--label-column-name", labelName, "--cache", cache };
+            parser.InvokeAsync(args).Wait();
+            Assert.IsTrue(parsingSuccessful);
+
+            parsingSuccessful = false;
+
+            cache = "off";
+            // valid cache test
+            args = new[] { "new", "--ml-task", "binary-classification", "--dataset", trainDataset, "--label-column-name", labelName, "--cache", cache };
+            parser.InvokeAsync(args).Wait();
+            Assert.IsTrue(parsingSuccessful);
+
+            parsingSuccessful = false;
+
+            cache = "auto";
+            // valid cache test
+            args = new[] { "new", "--ml-task", "binary-classification", "--dataset", trainDataset, "--label-column-name", labelName, "--cache", cache };
+            parser.InvokeAsync(args).Wait();
+            Assert.IsTrue(parsingSuccessful);
+
+            parsingSuccessful = false;
+
+            // invalid cache test
+            args = new[] { "new", "--ml-task", "binary-classification", "--dataset", trainDataset, "--label-column-name", labelName, "--cache", "blah" };
+            parser.InvokeAsync(args).Wait();
+            Assert.IsFalse(parsingSuccessful);
+
+            File.Delete(trainDataset);
+            File.Delete(testDataset);
+        }
     }
 }

src/mlnet/AutoML/AutoMLEngine.cs

@@ -14,12 +14,14 @@ internal class AutoMLEngine : IAutoMLEngine
     {
         private NewCommandSettings settings;
         private TaskKind taskKind;
+        private bool? enableCaching;
         private static Logger logger = LogManager.GetCurrentClassLogger();
 
         public AutoMLEngine(NewCommandSettings settings)
         {
             this.settings = settings;
             this.taskKind = Utils.GetTaskKind(settings.MlTask);
+            this.enableCaching = Utils.GetCacheSettings(settings.Cache);
         }
 
         public ColumnInferenceResults InferColumns(MLContext context)
@@ -53,7 +55,8 @@ public ColumnInferenceResults InferColumns(MLContext context)
                     .CreateBinaryClassificationExperiment(new BinaryExperimentSettings()
                     {
                         MaxExperimentTimeInSeconds = settings.MaxExplorationTime,
-                        ProgressHandler = progressReporter
+                        ProgressHandler = progressReporter,
+                        EnableCaching = this.enableCaching
                     })
                     .Execute(trainData, validationData, new ColumnInformation() { LabelColumn = labelName });
                 logger.Log(LogLevel.Info, Strings.RetrieveBestPipeline);
@@ -69,7 +72,8 @@ public ColumnInferenceResults InferColumns(MLContext context)
                     .CreateRegressionExperiment(new RegressionExperimentSettings()
                     {
                         MaxExperimentTimeInSeconds = settings.MaxExplorationTime,
-                        ProgressHandler = progressReporter
+                        ProgressHandler = progressReporter,
+                        EnableCaching = this.enableCaching
                     }).Execute(trainData, validationData, new ColumnInformation() { LabelColumn = labelName });
                 logger.Log(LogLevel.Info, Strings.RetrieveBestPipeline);
                 var bestIteration = result.Best();
@@ -84,7 +88,8 @@ public ColumnInferenceResults InferColumns(MLContext context)
                 var experimentSettings = new MulticlassExperimentSettings()
                 {
                     MaxExperimentTimeInSeconds = settings.MaxExplorationTime,
-                    ProgressHandler = progressReporter
+                    ProgressHandler = progressReporter,
+                    EnableCaching = this.enableCaching
                 };
 
                 // Inclusion list for currently supported learners. Need to remove once we have codegen support for all other learners.

src/mlnet/Commands/CommandDefinitions.cs

@@ -30,6 +30,7 @@ internal static System.CommandLine.Command New(ICommandHandler handler)
                                 Name(),
                                 OutputPath(),
                                 HasHeader(),
+                                Cache()
             };
 
             newCommand.Argument.AddValidator((sym) =>
@@ -99,6 +100,10 @@ Option HasHeader() =>
              new Option(new List<string>() { "--has-header" }, "Specify true/false depending if the dataset file(s) have a header row.",
             new Argument<bool>(defaultValue: true));
 
+            Option Cache() =>
+ new Option(new List<string>() { "--cache" }, "Specify on/off/auto if you want cache to be turned on, off or auto determined.",
+new Argument<string>(defaultValue: "auto").FromAmong(GetCacheSuggestions()));
+
         }
 
         private static string[] GetMlTaskSuggestions()
@@ -110,5 +115,10 @@ private static string[] GetVerbositySuggestions()
         {
             return new[] { "q", "m", "diag" };
         }
+
+        private static string[] GetCacheSuggestions()
+        {
+            return new[] { "on", "off", "auto" };
+        }
     }
 }

src/mlnet/Commands/New/NewCommandSettings.cs

@@ -30,5 +30,7 @@ public class NewCommandSettings
 
         public bool HasHeader { get; set; }
 
+        public string Cache { get; set; }
+
     }
 }

src/mlnet/Utilities/Utils.cs

@@ -79,5 +79,17 @@ internal static string Normalize(string input)
             }
         }
 
+        internal static bool? GetCacheSettings(string input)
+        {
+            switch (input)
+            {
+                case "on": return true;
+                case "off": return false;
+                case "auto": return null;
+                default:
+                    throw new ArgumentException($"{nameof(input)} is invalid", nameof(input));
+            }
+        }
+
     }
 }