chore: update eslint config

Author: xiejay97

.eslintrc.json

@@ -1,8 +1,8 @@
 {
   "root": true,
   "ignorePatterns": ["**/*"],
-  "extends": ["plugin:prettier/recommended"],
   "plugins": ["@nrwl/nx", "import", "markdown"],
+  "extends": ["plugin:prettier/recommended"],
   "overrides": [
     {
       "files": ["**/*.md"],
@@ -50,6 +50,7 @@
       "files": ["*.md", "*.ts", "*.tsx"],
       "extends": ["plugin:@nrwl/nx/typescript"],
       "rules": {
+        "no-unreachable": "error",
         "@typescript-eslint/array-type": [
           "error",
           {
@@ -108,7 +109,10 @@
             "ignoreProperties": true
           }
         ],
-        "no-unused-vars": "error"
+        "no-unused-vars": "off",
+        "@typescript-eslint/no-unused-vars": ["error"],
+        "no-unused-expressions": "off",
+        "@typescript-eslint/no-unused-expressions": ["error"]
       }
     },
     {

packages/site/src/app/components/route/DemoBox.tsx

@@ -20,7 +20,7 @@ export interface AppDemoBoxProps {
 }
 
 export function AppDemoBox(props: AppDemoBoxProps) {
-  // eslint-disable-next-line no-unused-vars
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   const { id, renderer, title, description, tsx, scss, tsxSource, scssSource } = props;
 
   const asyncCapture = useAsync();

packages/ui/src/components/menu/MenuGroup.tsx

@@ -20,7 +20,7 @@ export function DMenuGroup(props: DMenuGroupProps) {
     dId,
     dTitle,
     __level = 0,
-    // eslint-disable-next-line no-unused-vars
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     __navMenu = false,
     __onFocus,
     __onBlur,

packages/ui/src/components/menu/utils.ts

@@ -18,8 +18,6 @@ export function generateChildren(children: React.ReactNode, adjustIndicator = fa
       ..._child.props,
       className: adjustIndicator ? (_child.props.className ?? '' ? ` ${className}` : className) : _child.props.className,
     });
-
-    return child;
   });
 }